Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: OAuth 2.0 #1003

Open
helloanoop opened this issue Nov 20, 2023 · 67 comments
Open

Auth: OAuth 2.0 #1003

helloanoop opened this issue Nov 20, 2023 · 67 comments

Comments

@helloanoop
Copy link
Contributor

helloanoop commented Nov 20, 2023

Parent Issue: #119

Latest Update: 28 Nov 2024 See #1003 (comment)

Support OAuth 2.0

Related Issues

  1. Issues Related to current oauth flow
  1. Issues related to client credentials
  1. Other related issues:
@fuxx
Copy link

fuxx commented Nov 20, 2023

Really important feature <3

@and-rose
Copy link
Contributor

and-rose commented Dec 2, 2023

So far this is the only thing keeping me attached to Postman. Really keen to see this implemented.

@rjhofstee
Copy link

We would love to move to Bruno as well, but since we are requiring grant_type=authorization_code we can't yet. Is there maybe a progress update on this feature? 🙌

@tsteckenborn
Copy link

Dependend on what you need you might want to check this as a workaround for e.g. the Client Credentials flow.

@Rens660 - I've got quite a similar one for Authorization Code. You'll need to do one manual step in the browser, but atleast it returns e.g. the corresponding link as part of an error message. Would you be interested in that?

@rjhofstee
Copy link

Hi @tsteckenborn,
Unfortunately I am stuck with using Authorization Code, but if you would share your workaround for if, I am definitely interested, thanks!

@helloanoop
Copy link
Contributor Author

I will be building OAuth 2.0 functionality in this upcoming live coding stream with Hussain on Dec 16th
https://www.youtube.com/watch?v=ZtNGbglTjps

@tsteckenborn
Copy link

Hi @tsteckenborn, Unfortunately I am stuck with using Authorization Code, but if you would share your workaround for if, I am definitely interested, thanks!

Take a look if that helps to ease the usage

@42shadow42
Copy link

Pretty much the only thing tying me to insomnia. We use the implicit flow on our end.

@mjschlosser8
Copy link

Can't wait for this!

@andifalk
Copy link

andifalk commented Jan 9, 2024

Pretty much the only thing tying me to insomnia. We use the implicit flow on our end.

FYI: Implicit flow is deprecated, should not be used any more (replaced by Authorization code + PKCE)

@42shadow42
Copy link

Pretty much the only thing tying me to insomnia. We use the implicit flow on our end.

FYI: Implicit flow is deprecated, should not be used any more (replaced by Authorization code + PKCE)

Thanks for the heads up, though I don't see Authorization code + PKCE supported here yet either. I'll have to check to see if we have migration plans from Implicit flow.

@billbrinck
Copy link

Is there any progress on the OAuth2 support?

@fuxx
Copy link

fuxx commented Jan 11, 2024

Is there any progress on the OAuth2 support?

@helloanoop can you give any news on your progress or estimation when you continue on OAuth 2 support? The past weeks were very quiet around OAuth 2 😢

@helloanoop
Copy link
Contributor Author

@fuxx

Thanks for your patience.

I was a bit tied up in working on the lang improvements that will be needed to unblock some other features in the pipeline. Given the immense pain point and upvotes on this feature, I will spend some time on this week on this ticket and will share some updates towards the end of this week.

@fuxx
Copy link

fuxx commented Feb 1, 2024

Hej @helloanoop :)

Some weeks passed by and i guess the implementation could be more complicated then expected. Have you gained more insights on how you can proceed?

@helloanoop
Copy link
Contributor Author

Hey @fuxx Appreciate your patience.

A big blocker was the Bru Lang design which I wanted to complete. This was very important to ensure that we have a way forward to introduce more features in the future and seamlessly allow folks to migrate to the new format (expected to be available by end of Feb)

Now there are two things in my pipeline

  1. File Uploads - expected to be launched this week
  2. OAuth 2.0 - expected to launched by next week

I am not touching any other feature (except critical bugs) unless above 2 are launched.

@glitchracer
Copy link

Any news about OAuth 2.0 support?

lohxt1 pushed a commit to lohxt1/bruno that referenced this issue Feb 23, 2024
lohxt1 pushed a commit to lohxt1/bruno that referenced this issue Feb 23, 2024
lohxt1 pushed a commit to lohxt1/bruno that referenced this issue Feb 23, 2024
lohxt1 pushed a commit to lohxt1/bruno that referenced this issue Feb 23, 2024
lohxt1 pushed a commit to lohxt1/bruno that referenced this issue Feb 23, 2024
lohxt1 pushed a commit to lohxt1/bruno that referenced this issue Feb 23, 2024
helloanoop pushed a commit that referenced this issue Feb 26, 2024
…rization code, client credentials (#1654)

* feat(#1003): oauth2 support
Co-authored-by: lohit-1 <[email protected]>
@helloanoop
Copy link
Contributor Author

We're on the verge of completing OAuth2 integration, just polishing up the last details.
Set to release tomorrow.

image

lohxt1 added a commit to lohxt1/bruno that referenced this issue Feb 27, 2024
lohxt1 added a commit to lohxt1/bruno that referenced this issue Feb 27, 2024
lohxt1 added a commit to lohxt1/bruno that referenced this issue Feb 27, 2024
lizziemac pushed a commit to lizziemac/bruno that referenced this issue May 4, 2024
…word credentials grant types -- missing client id & secret for password grant type (usebruno#2051)

* fix(usebruno#1003): content type for client_credentials & password grant types
* feature(usebruno#1003): added client is & secret for password credentials grant type
lizziemac pushed a commit to lizziemac/bruno that referenced this issue May 4, 2024
helloanoop pushed a commit that referenced this issue May 22, 2024
…aracter from the response body (#2346)

* fix(#1003): content type for client_credentials & password grant types

* feature(#1003): added client is & secret for password credentials grant type

* fix: filter out non-printable control character and ZWNBSP character

* fix: filter out non-printable control character and ZWNBSP character
helloanoop added a commit that referenced this issue May 22, 2024
…t parse logic (#2351)

* fix(#1003): content type for client_credentials & password grant types

* feature(#1003): added client is & secret for password credentials grant type

* fix: filter out non-printable control character and ZWNBSP character

* fix: filter out non-printable control character and ZWNBSP character

* remove ZWNBSP character from response body

---------

Co-authored-by: Anoop M D <[email protected]>
pietrygamat added a commit to pietrygamat/bruno that referenced this issue May 22, 2024
@kkevindev
Copy link

kkevindev commented May 31, 2024

@helloanoop would it be possible for the Oauth2 implementation in Bruno to send extra headers/body request parameters. For example: we use Auth0 and we require a "organisation" request parameter to be send to the Oauth2 authentication endpoint. Currently, there is no functionality to send anything extra with the request.

pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 2, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 5, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 21, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jul 2, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jul 15, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jul 19, 2024
@pascalknupper
Copy link

Is there any update on this topic, can´t wait to see OAuth 2 auth flow without scripting in Bruno 🙂

lohxt1 pushed a commit that referenced this issue Jul 26, 2024
jwetzell pushed a commit to jwetzell/bruno that referenced this issue Aug 2, 2024
jwetzell pushed a commit to jwetzell/bruno that referenced this issue Aug 2, 2024
…aracter from the response body (usebruno#2346)

* fix(usebruno#1003): content type for client_credentials & password grant types

* feature(usebruno#1003): added client is & secret for password credentials grant type

* fix: filter out non-printable control character and ZWNBSP character

* fix: filter out non-printable control character and ZWNBSP character
jwetzell pushed a commit to jwetzell/bruno that referenced this issue Aug 2, 2024
…t parse logic (usebruno#2351)

* fix(usebruno#1003): content type for client_credentials & password grant types

* feature(usebruno#1003): added client is & secret for password credentials grant type

* fix: filter out non-printable control character and ZWNBSP character

* fix: filter out non-printable control character and ZWNBSP character

* remove ZWNBSP character from response body

---------

Co-authored-by: Anoop M D <[email protected]>
jwetzell pushed a commit to jwetzell/bruno that referenced this issue Aug 2, 2024
@StefanTUI
Copy link

Bruno is great! And I'd also love to see the OAuth2 auth flow (grant type client credentials) completed, so I fully recommend it everywhere I can :-)

@helloanoop
Copy link
Contributor Author

Hey everyone,

Thanks for all the feedback around improvements on the OAuth2 implementation. We know this has been on the wishlist for a while, and we’re finally diving into a full revamp of the OAuth2 flow. We’re aiming to wrap this up by end of December and will keep you posted here as we make progress.

As part of this process, we’re forming a cohort to better understand how you use OAuth2 in Bruno and gather insights into your expectations. If you’d like to join, please fill out this form: https://forms.gle/gicLNdt5F1XD1MBq7
In the discussions, we'd like to know and understand

  • How you’re currently using OAuth2 in Bruno.
  • Any challenges or limitations you’ve faced with the current implementation.
  • Features or improvements you’d like to see in the revamped version.

We are also reviewing the PRs - #2164, #2077, #2058 as a part of this effort.

Thanks,
Bruno Team

@JoniJnm
Copy link

JoniJnm commented Nov 28, 2024

How can I fill out the form?

I only wanted to say: I don't know if it's possible, but I would like to be able to open an external browser (instead of in-app) during the oauth2 authorization_code to use the local cookies and do not need to login every time in the external provider. Thanks.

image

@helloanoop
Copy link
Contributor Author

There was a permission issue in the cohort participation form. This has been fixed now.

@tygore587
Copy link

tygore587 commented Nov 28, 2024

How can I fill out the form?

I only wanted to say: I don't know if it's possible, but I would like to be able to open an external browser (instead of in-app) during the oauth2 authorization_code to use the local cookies and do not need to login every time in the external provider. Thanks.

Also a +1. We need to login with a device id in entra id. This device id is only send by edge or chrome with an extension and for this we need to login via an external browser.

Also it would be nice to do the authentication in the collection (like in postman). So i don't need to have 1 request that you need to run before you can run any other request in the collection. This is hard to understand for my team and it's the only reason nobody in my team uses the authentication with oauth2 in Bruno. Setting up oauth2 in the collection and running the auth request there is known to everybody and easier to understand for everyone.

@JoniJnm
Copy link

JoniJnm commented Dec 2, 2024

I created this ticket: #3584

@caviyacht
Copy link

I hope this comes out soon, I want to use Bruno (looks amazing) but am 100% reliant on the implicit grant flow. Any update as we're now in January?

@shonigbaum
Copy link

When is the OAuth 2.0 coming? Still getting a "invalid request" message when trying it:

Image

@bigsing
Copy link

bigsing commented Jan 31, 2025

@shonigbaum Per the Bruno Discord posted on 1/28:

Some polish is pending.
Here is a experimental build if you want to play around https://github.com/usebruno/bruno-experimental-builds/releases/tag/oauth2-revamp-v1.39.0-2025.1.24

Core functionality is done. We need to provide a setting to automatically fetch the token.
Let us know if you encounter any issues in the above build and if you have feedback on what else needs to be improved.

hoping to put out a public beta during feb first week and then release it live on feb 3rd week.

@abieler-sap
Copy link

abieler-sap commented Jan 31, 2025

I tried the experimental build and got an error fetching a token. Is there a possibility to analyze what went wrong?
Is there a plan to add the token request also to the timeline, so a user can see what's happening in the token request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests