From 7eedb74295f922688e1ba04ab17f3561abf81857 Mon Sep 17 00:00:00 2001 From: Michael Hiiva Date: Mon, 6 Dec 2021 15:50:20 -0800 Subject: [PATCH 1/4] refactor(file_name): generalizes file name for linting --- .github/workflows/{pre-commit.yml => linting.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{pre-commit.yml => linting.yml} (100%) diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/linting.yml similarity index 100% rename from .github/workflows/pre-commit.yml rename to .github/workflows/linting.yml From f8893055305c86710fafbfc0a5bd5eacf110db85 Mon Sep 17 00:00:00 2001 From: Michael Hiiva Date: Mon, 6 Dec 2021 15:59:25 -0800 Subject: [PATCH 2/4] feat(github): added an action for enforcing commitzen in pull-requests fix #238 --- .github/workflows/linting.yml | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index cf92d17c..8aa4ccec 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -1,11 +1,23 @@ name: pre-commit on: - pull_request: + pull_request_target: + types: + - opened + - edited + - synchronize + - reopened push: - branches: [master] + branches: [main] jobs: + semantics: + runs-on: ubuntu-latest + steps: + - uses: amannn/action-semantic-pull-request@v3.4.6 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + pre-commit: runs-on: ubuntu-latest steps: From 6e17fd6e056db8a90cbaa689b86ef3dded22cbc7 Mon Sep 17 00:00:00 2001 From: Michael Hiiva Date: Mon, 6 Dec 2021 16:10:25 -0800 Subject: [PATCH 3/4] docs: added a short description of our conventional commits usage and information on commitizen fix #238 --- README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e5864388..283b6eb4 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # The American Go Association Games Database (AGAGD) -The `AGAGD` application is what runs [agagd.usgo.org](https://agagd.usgo.org). Originally, ported from the EuroGo Games Database, the `AGAGD` application now provides a means for members and non-members tournament information, chapter informaiton and member insights. +The `AGAGD` application is what runs [agagd.usgo.org](https://agagd.usgo.org). Originally, ported from the EuroGo Games Database, the `AGAGD` application provides a means for members and non-members tournament information, chapter information and member insights. ## Contents @@ -14,7 +14,9 @@ The `AGAGD` application is what runs [agagd.usgo.org](https://agagd.usgo.org). O ## Contributing -We welcome any contributions. You could update documentation or our getting started or add a feature or find another way to improve the `AGAGD` application. Any contributions should be submitted as Pull Requests (PR). If you new to contributing on Github, take a look a the [First Contributions](https://firstcontributions.github.io/) project. +We welcome any contributions. You could update documentation or our getting started or add a feature or find another way to improve the `AGAGD` application. Any contributions should be submitted as Pull Requests (PR) with [Conventional Commit(s) Messages](https://www.conventionalcommits.org). You can use the [CZ Cli](https://github.com/commitizen/cz-cli) tool if you would like a conventional commit message aid. + +If you new to contributing on Github, take a look a the [First Contributions](https://firstcontributions.github.io/) project. ## Requirements From 3fc6e5f66cd92ad831072800f2459ae990b099cd Mon Sep 17 00:00:00 2001 From: Michael Hiiva Date: Mon, 6 Dec 2021 16:15:38 -0800 Subject: [PATCH 4/4] refactor: removed on push from linting --- .github/workflows/linting.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 8aa4ccec..3acd3be7 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -1,4 +1,4 @@ -name: pre-commit +name: lint on: pull_request_target: @@ -7,8 +7,6 @@ on: - edited - synchronize - reopened - push: - branches: [main] jobs: semantics: