From 718239756dc8540d74a0ae53fdaf669e464e6363 Mon Sep 17 00:00:00 2001
From: rohit645 <kumarnath.rohit@gmail.com>
Date: Fri, 3 Apr 2020 22:32:05 +0530
Subject: [PATCH 1/4] removed private toggle button from survey-edit window

---
 app/settings/surveys/attribute-editor.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/settings/surveys/attribute-editor.html b/app/settings/surveys/attribute-editor.html
index 15f98c7622..57dbe7230a 100644
--- a/app/settings/surveys/attribute-editor.html
+++ b/app/settings/surveys/attribute-editor.html
@@ -79,7 +79,7 @@
          </div>
        </div>
        <!-- end: media upload toggle to make caption an optional field-->
-       <div class="form-field switch" ng-show="canMakePrivate()">
+       <!-- <div class="form-field switch" ng-show="canMakePrivate()">
           <label translate="survey.make_response_private">Make responses private</label>
           <p data-fieldgroup-target="field-private-message-3" class="init active" translate="survey.response_private_desc" ng-show="editAttribute.response_private">
             <svg class="iconic">
@@ -91,7 +91,7 @@
              <input class="tgl" id="switchprivateresponse" type="checkbox" ng-model="editAttribute.response_private">
              <label class="tgl-btn" for="switchprivateresponse"></label>
           </div>
-       </div>
+       </div> -->
        <div class="form-field switch" ng-if="canDisplay()">
             <label translate="app.default_value">Default value (optional):</label>
             <div class="form-field">

From eb486406b62776a69d2308eaeca26af47639bd5d Mon Sep 17 00:00:00 2001
From: rohit645 <kumarnath.rohit@gmail.com>
Date: Mon, 6 Apr 2020 09:54:16 +0530
Subject: [PATCH 2/4] requested changes made

---
 app/settings/surveys/attribute-editor.directive.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/settings/surveys/attribute-editor.directive.js b/app/settings/surveys/attribute-editor.directive.js
index 7700b4eea7..c778ed2c9a 100644
--- a/app/settings/surveys/attribute-editor.directive.js
+++ b/app/settings/surveys/attribute-editor.directive.js
@@ -70,7 +70,7 @@ function (
             };
 
             $scope.canMakePrivate = function () {
-                return $scope.editAttribute.type !== 'tags';
+                return $scope.editAttribute.type !== 'tags' && $scope.editAttribute.type !== 'title' && $scope.editAttribute.type !== 'description';
             };
 
             $scope.canDisableCaption = function () {

From 8c5d2e775ede15ef59db7f773f89be14315ea7cb Mon Sep 17 00:00:00 2001
From: rohit645 <kumarnath.rohit@gmail.com>
Date: Tue, 7 Apr 2020 08:37:51 +0530
Subject: [PATCH 3/4] fixed error due to previous commit

---
 app/settings/surveys/attribute-editor.html | 26 +++++++++++-----------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/app/settings/surveys/attribute-editor.html b/app/settings/surveys/attribute-editor.html
index 57dbe7230a..7f6b417aa4 100644
--- a/app/settings/surveys/attribute-editor.html
+++ b/app/settings/surveys/attribute-editor.html
@@ -79,19 +79,19 @@
          </div>
        </div>
        <!-- end: media upload toggle to make caption an optional field-->
-       <!-- <div class="form-field switch" ng-show="canMakePrivate()">
-          <label translate="survey.make_response_private">Make responses private</label>
-          <p data-fieldgroup-target="field-private-message-3" class="init active" translate="survey.response_private_desc" ng-show="editAttribute.response_private">
-            <svg class="iconic">
-              <use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="/img/iconic-sprite.svg#lock-locked"></use>
-            </svg>
-              Only people with permission to edit responses will be able to see responses to this field.
-          </p>
-          <div class="toggle-switch">
-             <input class="tgl" id="switchprivateresponse" type="checkbox" ng-model="editAttribute.response_private">
-             <label class="tgl-btn" for="switchprivateresponse"></label>
-          </div>
-       </div> -->
+       <div class="form-field switch" ng-show="canMakePrivate()">
+        <label translate="survey.make_response_private">Make responses private</label>
+        <p data-fieldgroup-target="field-private-message-3" class="init active" translate="survey.response_private_desc" ng-show="editAttribute.response_private">
+          <svg class="iconic">
+            <use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="/img/iconic-sprite.svg#lock-locked"></use>
+          </svg>
+            Only people with permission to edit responses will be able to see responses to this field.
+        </p>
+        <div class="toggle-switch">
+           <input class="tgl" id="switchprivateresponse" type="checkbox" ng-model="editAttribute.response_private">
+           <label class="tgl-btn" for="switchprivateresponse"></label>
+        </div>
+     </div>
        <div class="form-field switch" ng-if="canDisplay()">
             <label translate="app.default_value">Default value (optional):</label>
             <div class="form-field">

From 8504425ce81b56498873ea595ea51b8da2779aba Mon Sep 17 00:00:00 2001
From: rohit645 <kumarnath.rohit@gmail.com>
Date: Tue, 7 Apr 2020 08:41:23 +0530
Subject: [PATCH 4/4] indentation

---
 app/settings/surveys/attribute-editor.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/settings/surveys/attribute-editor.html b/app/settings/surveys/attribute-editor.html
index 7f6b417aa4..9f4b642bbb 100644
--- a/app/settings/surveys/attribute-editor.html
+++ b/app/settings/surveys/attribute-editor.html
@@ -91,7 +91,7 @@
            <input class="tgl" id="switchprivateresponse" type="checkbox" ng-model="editAttribute.response_private">
            <label class="tgl-btn" for="switchprivateresponse"></label>
         </div>
-     </div>
+       </div>
        <div class="form-field switch" ng-if="canDisplay()">
             <label translate="app.default_value">Default value (optional):</label>
             <div class="form-field">