Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages that require additional review and corrections based on new artifacts in OSCAL #27

Closed
Compton-US opened this issue Jul 26, 2023 · 2 comments · Fixed by #28
Closed
Assignees

Comments

@Compton-US
Copy link
Contributor

Compton-US commented Jul 26, 2023

These files need review:

./src/content/concepts/layer/assessment/assessment-plan/_index.md
./src/content/concepts/layer/assessment/assessment-results/_index.md
./src/content/concepts/layer/assessment/poam/_index.md
./src/content/concepts/layer/control/catalog/_index.md
./src/content/concepts/layer/control/profile/_index.md
./src/content/concepts/layer/implementation/component-definition/_index.md
./src/content/concepts/layer/implementation/ssp/_index.md
./src/content/concepts/layer/overview.md
./src/content/learn/tutorials/general/releases.md
./src/content/tools/_index.md

They contain content that links to the json/xml schema documents in source, but it may not always be a simple url fix. It may require some adjustment of the content to match the link.

For now, we are linking schema and converter artifacts as v1.1.0 release content. This is required to specifically link to a json, xml, xsd, etc. A fix will be coming for this soon, but we are hard coding to the version for now.

In some cases, when the reference is generally to all artifacts, a link to https://github.com/usnistgov/OSCAL/releases/latest may be sufficient.

Lastly, there are some links to the old readme on how to use the converter. See README from v1.0.5 This document may need to be brought over into the website for those links to reference. ./src/content/concepts/layer/control/profile/_index.md:18is has an example under the How do I use this? link.

@Compton-US
Copy link
Contributor Author

@aj-stein-nist Question on this one is if we need to bring over the readme that was deleted from OSCAL, or if there are revised directions/links needed based on the Makefile approach we've moved to.

@nikitawootten-nist nikitawootten-nist self-assigned this Aug 1, 2023
@nikitawootten-nist nikitawootten-nist moved this from Todo to In Progress in NIST OSCAL Work Board Aug 1, 2023
nikitawootten-nist added a commit to nikitawootten-nist/OSCAL-Pages that referenced this issue Aug 1, 2023
@nikitawootten-nist nikitawootten-nist linked a pull request Aug 1, 2023 that will close this issue
2 tasks
@nikitawootten-nist nikitawootten-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Aug 1, 2023
nikitawootten-nist added a commit to nikitawootten-nist/OSCAL-Pages that referenced this issue Aug 1, 2023
@aj-stein-nist
Copy link
Collaborator

Forward this to Sprint 74 and consult with @nikitawootten-nist when available.

@nikitawootten-nist nikitawootten-nist moved this from Under Review to Reviewer Approved in NIST OSCAL Work Board Aug 24, 2023
aj-stein-nist added a commit that referenced this issue Aug 29, 2023
* Realign pages to link to release assets (#27)

* Apply suggestions from code review

Co-authored-by: A.J. Stein <[email protected]>

---------

Co-authored-by: A.J. Stein <[email protected]>
Arminta-Jenkins-NIST pushed a commit that referenced this issue Sep 12, 2023
* Realign pages to link to release assets (#27)

* Apply suggestions from code review

Co-authored-by: A.J. Stein <[email protected]>

---------

Co-authored-by: A.J. Stein <[email protected]>
@aj-stein-nist aj-stein-nist moved this from Reviewer Approved to Done in NIST OSCAL Work Board Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants