Fixed Broken Link Issues (#80, #81, #82) and Updated Mini Workshops Page #87
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the date of the event Co-authored-by: selenaxiao-nist <[email protected]>
Fixed typo Co-authored-by: selenaxiao-nist <[email protected]>
iMichaela
reviewed
Nov 27, 2024
iMichaela
requested changes
Nov 27, 2024
|
Hi Marilyn,
I reviewed your PR and had one suggestion for the issue #81. You included a full path instead the relative one (in addition to correcting it by removing _index.md. When doing so, local testing with link-checker will not work or check a link to a site online and not the one you built locally. Full path is recommended for all other URLs that are not part of our website.
Also, the date at the bottom of all pages is read from github.
The rest looks good. Bravo!
Can you correct the hyperlink but keep it relative? Thank you.
Michaela
“The happiest people are not those getting
more, but those giving more.”
― Jackson Brown Jr.
From: Marilyn Nguyen ***@***.***>
Date: Tuesday, November 26, 2024 at 11:51 AM
To: usnistgov/OSCAL-Pages ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [usnistgov/OSCAL-Pages] Fixed Broken Link Issues (#80, #81, #82) and Updated Mini Workshops Page (PR #87)
Here is a list of issues fixed and updates made:
1. Fixed broken links on Blogs Page (Issue #80<#80>)
2. Fixed Link to "Tools Page" (Issue #81<#81>)
3. Fixed OSCAL v1.1.1 Release Link (Issue #82<#82>)
4. Updated the OSCAL Mini Workshops file to include the November 6th, 2024 and November 20th, 2024 Mini Workshops' documentations.
…________________________________
You can view, comment on, or merge this pull request online at:
#87
Commit Summary
* c43fc78<c43fc78> Updated Mini-workshop events and added 4th OSCAL workshop
* 3cc7b21<3cc7b21> Updated mini-workshop page
* 0c5114f<0c5114f> Rearranged the side navigation bar
* e9480a8<e9480a8> Update src/content/learn/presentations/oscal-workshop-2023-04.md
* f91fb94<f91fb94> Update src/content/learn/presentations/_index.md
* 3f5757a<3f5757a> Merge branch 'usnistgov:develop' into develop
* 51a1f61<51a1f61> Fixed Broken Links on 2 Pages
* 153b137<153b137> Added November 2024 Mini Workshop Documentation
File Changes
(3 files<https://github.com/usnistgov/OSCAL-Pages/pull/87/files>)
* M src/content/about/blog/oscal-first-deep-cleaning.md<https://github.com/usnistgov/OSCAL-Pages/pull/87/files#diff-f6ee3a378f76db497c8f43a5dc0ab8da332f409678d24be68e71fb4a8de01f21> (2)
* M src/content/learn/presentations/mini-workshop/_index.md<https://github.com/usnistgov/OSCAL-Pages/pull/87/files#diff-bf443398ab95b90eabf4b424eedc925860ca7a73d24b43be6bc29920a9e8410a> (4)
* M src/content/resources/concepts/layer/overview.md<https://github.com/usnistgov/OSCAL-Pages/pull/87/files#diff-d160d0f60a745d15116128459fe2c05dae282968102b9104ad43f2b694c7ba01> (2)
Patch Links:
* https://github.com/usnistgov/OSCAL-Pages/pull/87.patch
* https://github.com/usnistgov/OSCAL-Pages/pull/87.diff
—
Reply to this email directly, view it on GitHub<#87>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADKWGIO7PBPO4YMXC46EWV32CSRHFAVCNFSM6AAAAABSQ4UBQOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4TKMZXHEZTCNY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
selenaxiao-nist
approved these changes
Jan 2, 2025
This was
linked to
issues
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a list of issues fixed and updates made: