Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in Clojure 1.9 #1

Closed
bcambel opened this issue Mar 1, 2018 · 8 comments
Closed

Exceptions in Clojure 1.9 #1

bcambel opened this issue Mar 1, 2018 · 8 comments

Comments

@bcambel
Copy link

bcambel commented Mar 1, 2018

Hi,

Such a great project first of all. Thanks for all the great work. I am trying to run it under clojure 1.9 and having the following exception. Did you able to run with the 1.9 ?

clojure.lang.ExceptionInfo: Call to clojure.core/refer-clojure did not conform to spec:
                                         In: [2 1] val: :as fails at: [:args :exclude :op :quoted-spec :spec] predicate: #{:exclude}
                                         In: [2 1] val: :as fails at: [:args :only :op :quoted-spec :spec] predicate: #{:only}
                                         In: [2 1] val: :as fails at: [:args :rename :op :quoted-spec :spec] predicate: #{:rename}
                                         In: [2] val: (quote :as) fails at: [:args :exclude :op :spec] predicate: #{:exclude}
                                         In: [2] val: (quote :as) fails at: [:args :only :op :spec] predicate: #{:only}
                                         In: [2] val: (quote :as) fails at: [:args :rename :op :spec] predicate: #{:rename}
                                         
clojure.lang.Compiler$CompilerException: clojure.lang.ExceptionInfo: Call to clojure.core/refer-clojure did not conform to spec:
                                         In: [2 1] val: :as fails at: [:args :exclude :op :quoted-spec :spec] predicate: #{:exclude}
                                         In: [2 1] val: :as fails at: [:args :only :op :quoted-spec :spec] predicate: #{:only}
                                         In: [2 1] val: :as fails at: [:args :rename :op :quoted-spec :spec] predicate: #{:rename}
                                         In: [2] val: (quote :as) fails at: [:args :exclude :op :spec] predicate: #{:exclude}
                                         In: [2] val: (quote :as) fails at: [:args :only :op :spec] predicate: #{:only}
                                         In: [2] val: (quote :as) fails at: [:args :rename :op :spec] predicate: #{:rename}
                                          #:clojure.spec.alpha{:problems ({:path [:args :exclude :op :spec], :pred #{:exclude}, :val (quote :as), :via [], :in [2]} {:path [:args :exclude :op :quoted-spec :spec], :pred #{:exclude}, :val :as, :via [], :in [2 1]} {:path [:args :only :op :spec], :pred #{:only}, :val (quote :as), :via [], :in [2]} {:path [:args :only :op :quoted-spec :spec], :pred #{:only}, :val :as, :via [], :in [2 1]} {:path [:args :rename :op :spec], :pred #{:rename}, :val (quote :as), :via [], :in [2]} {:path [:args :rename :op :quoted-spec :spec], :pred #{:rename}, :val :as, :via [], :in [2 1]}), :spec #object[clojure.spec.alpha$regex_spec_impl$reify__2436 0x70fdc201 "clojure.spec.alpha$regex_spec_impl$reify__2436@70fdc201"], :value ((quote :exclude) (quote [reduce transduce into merge map take partition partition-by bounded-count]) (quote :as) (quote core)), :args ((quote :exclude) (quote [reduce transduce into merge map take partition partition-by bounded-count]) (quote :as) (quote core))}, compiling:(clojure/core/async.clj:9:1)

@tirkarthi
Copy link

This is due to using an older version core.async that is not compatible with Clojure 1.9 . This is fixed at clojure/core.async@2f87bc7 . Also I could see this project uses Clojure 1.9 - alpha 14. Since Clojure 1.9 is stable both core.async and clojure could be upgraded.

@tirkarthi
Copy link

To add to this discussion this project fails in JDK 9 . It uses a version of alembic that fails under JDK 9 with an older version of dynapath (latest version of dynapath is JDK 9 compatible). There is a PR waiting to be merged upstream pallet/alembic#16 which could help in running stepwise under JDK 9.

Thanks.

@spieden
Copy link
Collaborator

spieden commented Mar 20, 2018

Hey guys, sorry been away. We're running 1.9 in production now and I'll be making a new release of stepwise in the next couple days with some other enhancements as well.

@spieden
Copy link
Collaborator

spieden commented Mar 20, 2018

Ok 0.5.8-SNAPSHOT is Clojure 1.9 and JDK 9 compatible by temporarily disabling alembic (it's only used in dev repls), migrating to spec.alpha, and bumping core.async's version.

I also updated the AWS SDK version, which the enhancements I mentioned depend on, but those will come later this week.

Cheers!

@spieden spieden closed this as completed Mar 20, 2018
@spieden spieden reopened this Mar 20, 2018
@spieden
Copy link
Collaborator

spieden commented Mar 20, 2018

Reopened for visibility until there's a release version with the fixes

@spieden
Copy link
Collaborator

spieden commented Apr 2, 2018

Ok, fixed in version 0.5.8

@spieden spieden closed this as completed Apr 2, 2018
@tirkarthi
Copy link

Thanks

@bcambel
Copy link
Author

bcambel commented May 27, 2018

Thanks @spieden 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants