Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ban command purge duration behavior #520

Open
hyper-neutrino opened this issue May 17, 2024 · 0 comments · May be fixed by #528
Open

Improve ban command purge duration behavior #520

hyper-neutrino opened this issue May 17, 2024 · 0 comments · May be fixed by #528
Assignees
Labels
enhancement Improvements on existing work

Comments

@hyper-neutrino
Copy link
Contributor

hyper-neutrino commented May 17, 2024

The ban command currently just accepts a number of days. If an invalid number of days is provided (e.g. more than 7), a generic fatal error will be shown and the command will crash and be logged.

Now that Discord allows bans to purge any number of seconds between 0 and 7 days, we should improve this to parse the user's input to determine exactly how much time, and a proper error messages should be shown for invalid inputs.

@hyper-neutrino hyper-neutrino added enhancement Improvements on existing work good first issue Good for newcomers labels May 17, 2024
@hyper-neutrino hyper-neutrino self-assigned this Jun 18, 2024
@w1dering w1dering assigned w1dering and unassigned w1dering Sep 28, 2024
@KuroganeToyama KuroganeToyama removed the good first issue Good for newcomers label Sep 28, 2024
@KuroganeToyama KuroganeToyama linked a pull request Sep 28, 2024 that will close this issue
@KuroganeToyama KuroganeToyama self-assigned this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements on existing work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants