Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide focus outline on overlay items when using pointer input #8522

Open
sissbruecker opened this issue Jan 16, 2025 · 0 comments
Open

Hide focus outline on overlay items when using pointer input #8522

sissbruecker opened this issue Jan 16, 2025 · 0 comments

Comments

@sissbruecker
Copy link
Contributor

sissbruecker commented Jan 16, 2025

Currently some components show a focus outline on an item when opening their overlay using pointer input:

  • vaadin-select - Shows focus outline on first or selected item
  • vaadin-context-menu - Shows focus outline on first menu item

Compared to that other components do not show a focus outline when opening their overlay: vaadin-combo-box, vaadin-menu-bar

We briefly discussed this when implementing the pointer focus ring and concluded that a focus outline around an item should only be shown when using keyboard navigation, but not with pointer input.

One open point was what should happen with the focus itself. It should probably still move into the overlay, on some item, to allow switching from mouse to keyboard for example.

Another thing to note is that if the pointer focus ring is enabled, then we might still want to show a focus outline around the vaadin-select button, as otherwise no focus outline would be visible anymore. Currently the pointer focus ring is not implemented for vaadin-select. See #2904 for more info about that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants