Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing ItemsSource selects the first item #27

Closed
tmijail opened this issue Apr 20, 2023 · 1 comment · May be fixed by #29
Closed

Changing ItemsSource selects the first item #27

tmijail opened this issue Apr 20, 2023 · 1 comment · May be fixed by #29

Comments

@tmijail
Copy link
Contributor

tmijail commented Apr 20, 2023

Current behaviour:

Since the 1.5 update, whenever ItemsSource is changed, SelectedItem is set to the first item in ItemsSource. This overwrites any selection that the user might have previously made.

AutoCompleteComboBox.bug.mp4

Expected behaviour:

If SelectedItem exists in the new ItemsSource, it shouldn't change. If it doesn't, the selection should be cleared.

Steps to reproduce:

See the demo in this branch. Specifically, this commit.
@tmijail tmijail mentioned this issue Apr 20, 2023
Merged
vain0x added a commit that referenced this issue Apr 22, 2023
@vain0x
Merge remote-tracking branch 'tmijail/ItemsSource-bug-fix' (#27)
2994497
@vain0x vain0x closed this as completed in 90fa51f Apr 22, 2023
@vain0x
Copy link
Owner

vain0x commented Apr 22, 2023

Thank you! Released in v1.6.0.

@kvpt kvpt mentioned this issue May 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tmijail @vain0x