Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make valence_protocol usable for other projects #585

Open
CryptForge opened this issue Nov 29, 2023 · 1 comment
Open

Make valence_protocol usable for other projects #585

CryptForge opened this issue Nov 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@CryptForge
Copy link

Describe the problem related to your feature request.

I'm working on my own project and I realized that there isn't a good minecraft protocol crate.
valence_protocol is good, but it's very interwoven with the rest of valence.

What solution would you like?

Ideally the protocol would be a completely separate project, but that would require a lot of changes and the seperation of other valence crates.
So a (relatively) simple change could be to remove unnecessary dependencies from valence_protocol, mainly bevy_ecs.

What alternative(s) have you considered?

I'm currently making a new protocol crate, but I'd rather just use an already existing one.

@CryptForge CryptForge added the enhancement New feature or request label Nov 29, 2023
@rj00a
Copy link
Member

rj00a commented Nov 30, 2023

The intent was always to make bevy_ecs an optional dependency but I never got around to it. That should be easy since it's just used for #[derive(Component)] in a few places. base64 and url could probably be cut too.

Other than that, I don't think valence_protocol can be made any less opinionated than it already is, due to all the different domains it needs to touch. Dependencies like valence_text, valence_ident, and valence_nbt are intended to be usable as standalone crates too.

@rj00a rj00a linked a pull request Feb 11, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants