Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide valkeyContext #52

Open
pizhenwei opened this issue Jul 16, 2024 · 0 comments
Open

Hide valkeyContext #52

pizhenwei opened this issue Jul 16, 2024 · 0 comments

Comments

@pizhenwei
Copy link
Contributor

Hi,

I'd like to hide valkeyContext into libvalkey internal data structure with several changes:

  • use typedef void *valkeyContext; instead in valkey.h, redefine struct valkeyContext in valkey_private.h
  • use valkeyContextGetErr(valkeyContext c) instead of c->err, also apply this rule to c->errstr

Does anything block this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pizhenwei