Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IFEQ option for SET command #2811

Closed
4 tasks done
hpatro opened this issue Dec 12, 2024 · 7 comments
Closed
4 tasks done

Support IFEQ option for SET command #2811

hpatro opened this issue Dec 12, 2024 · 7 comments
Assignees
Labels
All Wrappers issue Issue relevant to all wrrappers. good first issue Good for newcomers
Milestone

Comments

@hpatro
Copy link

hpatro commented Dec 12, 2024

Describe the feature

Support IFEQ option for SET command with valkey-glide clients. Additional option is planned to be added to SET command in Valkey 8.1

valkey-io/valkey-doc#189

Use Case

Explained in valkey-io/valkey#1215 and implemented in valkey-io/valkey#1324

Checklist

@avifenesh
Copy link
Member

Hi @hpatro ☺️
Thanks for the heads up! Will add it to our planning.
If you want to contribute it, i will be happy to give you a tour.

@avifenesh avifenesh added good first issue Good for newcomers 1_3_candidate All Wrappers issue Issue relevant to all wrrappers. labels Dec 12, 2024
@hpatro
Copy link
Author

hpatro commented Dec 13, 2024

Hi @hpatro ☺️ Thanks for the heads up! Will add it to our planning. If you want to contribute it, i will be happy to give you a tour.

Thanks @avifenesh. I also wanted to understand the architecture of valkey glide better. Will reachout.

@avifenesh
Copy link
Member

Hi @hpatro ☺️ Thanks for the heads up! Will add it to our planning. If you want to contribute it, i will be happy to give you a tour.

Thanks @avifenesh. I also wanted to understand the architecture of valkey glide better. Will reachout.

You can find me both on Valkey slack as well in AWS.
Feel free when you feel like, always happy to chat :)

@asafpamzn asafpamzn added this to the 1.3 milestone Dec 25, 2024
@Maayanshani25
Copy link
Collaborator

The implementation requires modifying the set command and adding separate and integrated test cases with other SET options like GET and EX.
Estimation: 6 days.

@avifenesh
Copy link
Member

@Maayanshani25 Hi brother, hope you're enjoying your trip! :)
Please note that I'm assigning the Python implementation to @Angraybill.
If you want to talk about it, ping ♥️

@avifenesh
Copy link
Member

@hpatro Until now, the options for conditional change values were the same for SET as for GEOADD and ZADD.
IFEQ is for SET only, require some additions in the type system, since we need to enforce using IFEQ in SET only and not in the other. Hence, it cannot be part of the ConditionalChange Enum.
Before we create the new changes, for planing it right for the future to avoid breaking changes, or extra and redundant types - Is it possible that it will be added to the other commands?
I understand that those will require deep equal check and not just equal, and you can't see the future, but maybe you have some clue about the possibilities.

@tjzhang-BQ
Copy link
Collaborator

Merged golang changes to the main branch, closing this issue now

@github-project-automation github-project-automation bot moved this from In Progress to Done in Valkey-GLIDE - internal Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
All Wrappers issue Issue relevant to all wrrappers. good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

7 participants