Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate unit tests to new framework #428

Closed
12 tasks done
madolson opened this issue May 3, 2024 · 4 comments · Fixed by #515
Closed
12 tasks done

Migrate unit tests to new framework #428

madolson opened this issue May 3, 2024 · 4 comments · Fixed by #515
Labels
good first issue Good for newcomers help wanted External contributions would be appreciated

Comments

@madolson
Copy link
Member

madolson commented May 3, 2024

The legacy unit tests were a collection of distinct tests stored at the bottom of various files, that required rebuilding the server with a special flag and starting the server. We're moving to a new framework that can always be built and are running on a unified infrastructure. This issue is keeping track of migration from the old to new framework.

To migrate the tests, remove the custom testing code in the testing file lists listed below, create a new test like src/unit/test_*.c, and remove the reference in

struct serverTest {
. See the README for more information about writing a new unit test.

@madolson madolson added help wanted External contributions would be appreciated good first issue Good for newcomers labels May 3, 2024
madolson pushed a commit that referenced this issue May 7, 2024
This PR fixes an error in the unit/READMED.md (see
#428) in order to correct the
steps for running single unit test file.

Signed-off-by: Karthick Ariyaratnam <[email protected]>
madolson pushed a commit that referenced this issue May 7, 2024
This PR migrates all tests related to util into new test framework as
part of the parent issue #428.

---------

Signed-off-by: Karthick Ariyaratnam <[email protected]>
madolson added a commit that referenced this issue May 7, 2024
This PR migrates all tests related to kvstore into new test framework as
part of the parent issue #428.

---------

Signed-off-by: Karthick Ariyaratnam <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
madolson added a commit that referenced this issue May 9, 2024
This patch migrates all tests in sds.c into new test framework as part
of the parent issue #428.

---------

Signed-off-by: Lipeng Zhu <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
madolson added a commit that referenced this issue May 10, 2024
This migrates unit tests related to sha1 to new framework, ref: #428.

---------

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
madolson added a commit that referenced this issue May 12, 2024
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue #428.

---------

Signed-off-by: Karthick Ariyaratnam <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
karthyuom added a commit to karthyuom/valkey that referenced this issue May 13, 2024
This PR migrates all tests related to util into new test framework as
part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <[email protected]>

Signed-off-by: Karthick Ariyaratnam <[email protected]>
karthyuom added a commit to karthyuom/valkey that referenced this issue May 13, 2024
This PR migrates all tests related to kvstore into new test framework as
part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>

Signed-off-by: Karthick Ariyaratnam <[email protected]>
karthyuom pushed a commit to karthyuom/valkey that referenced this issue May 13, 2024
This patch migrates all tests in sds.c into new test framework as part
of the parent issue valkey-io#428.

---------

Signed-off-by: Lipeng Zhu <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>

Signed-off-by: Karthick Ariyaratnam <[email protected]>
karthyuom pushed a commit to karthyuom/valkey that referenced this issue May 13, 2024
This migrates unit tests related to sha1 to new framework, ref: valkey-io#428.

---------

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>

Signed-off-by: Karthick Ariyaratnam <[email protected]>
madolson pushed a commit that referenced this issue May 14, 2024
This is the actual PR which is created to migrate all tests related to
zmalloc into new test framework as part of the parent issue
#428.

Signed-off-by: Karthick Ariyaratnam <[email protected]>
adetunjii pushed a commit to adetunjii/valkey that referenced this issue May 15, 2024
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
adetunjii pushed a commit to adetunjii/valkey that referenced this issue May 15, 2024
)

This is the actual PR which is created to migrate all tests related to
zmalloc into new test framework as part of the parent issue
valkey-io#428.

Signed-off-by: Karthick Ariyaratnam <[email protected]>
adetunjii pushed a commit to adetunjii/valkey that referenced this issue May 15, 2024
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: adetunjii <[email protected]>
hwware added a commit that referenced this issue Aug 29, 2024
Migrate zipmap unit test to new unit test framework, parent ticket #428
.

---------

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: hwware <[email protected]>
Co-authored-by: hwware <[email protected]>
hwware pushed a commit to haoqixu/valkey that referenced this issue Aug 29, 2024
haoqixu added a commit to haoqixu/valkey that referenced this issue Aug 31, 2024
madolson pushed a commit that referenced this issue Sep 2, 2024
Migrate zipmap unit test to new unit test framework, parent ticket #428
.

---------

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: hwware <[email protected]>
Co-authored-by: hwware <[email protected]>
madolson pushed a commit that referenced this issue Sep 3, 2024
Migrate zipmap unit test to new unit test framework, parent ticket #428
.

---------

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: hwware <[email protected]>
Co-authored-by: hwware <[email protected]>
haoqixu added a commit to haoqixu/valkey that referenced this issue Sep 9, 2024
enjoy-binbin added a commit that referenced this issue Sep 9, 2024
This PR migrates the tests related to listpack into new test framework
as part of #428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
enjoy-binbin added a commit that referenced this issue Sep 9, 2024
This PR migrates the tests related to dict into new test framework as
part of #428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
PingXie added a commit to PingXie/valkey that referenced this issue Sep 14, 2024
Migrate zipmap unit test to new unit test framework, parent ticket valkey-io#428
.

---------

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: hwware <[email protected]>
Co-authored-by: hwware <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to listpack into new test framework
as part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to dict into new test framework as
part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie added a commit to PingXie/valkey that referenced this issue Sep 14, 2024
Migrate zipmap unit test to new unit test framework, parent ticket valkey-io#428
.

---------

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: hwware <[email protected]>
Co-authored-by: hwware <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to listpack into new test framework
as part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to dict into new test framework as
part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie added a commit to PingXie/valkey that referenced this issue Sep 14, 2024
Migrate zipmap unit test to new unit test framework, parent ticket valkey-io#428
.

---------

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: hwware <[email protected]>
Co-authored-by: hwware <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to listpack into new test framework
as part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to dict into new test framework as
part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
enjoy-binbin added a commit to enjoy-binbin/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to listpack into new test framework
as part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
enjoy-binbin added a commit to enjoy-binbin/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to dict into new test framework as
part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to listpack into new test framework
as part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to dict into new test framework as
part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to listpack into new test framework
as part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this issue Sep 14, 2024
This PR migrates the tests related to dict into new test framework as
part of valkey-io#428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit that referenced this issue Sep 15, 2024
This PR migrates the tests related to listpack into new test framework
as part of #428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie pushed a commit that referenced this issue Sep 15, 2024
This PR migrates the tests related to dict into new test framework as
part of #428.

Signed-off-by: haoqixu <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
@enjoy-binbin enjoy-binbin linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted External contributions would be appreciated
Projects
None yet
4 participants