Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Add -fPIC Flag in .a File Compilation #65

Open
PureWhiteWu opened this issue Jan 7, 2025 · 0 comments
Open

Request to Add -fPIC Flag in .a File Compilation #65

PureWhiteWu opened this issue Jan 7, 2025 · 0 comments

Comments

@PureWhiteWu
Copy link

Hello,

First, thank you for maintaining the gozstd library—it has been a critical dependency in our projects.

We’ve encountered an issue related to the lack of the -fPIC flag when compiling the .a files in the library. Specifically, this absence causes a compilation conflict when gozstd is used alongside another internal library in our company. This conflict results in build failures, and unfortunately, we are unable to ask all our users to manually replace the gozstd dependency.

Adding the -fPIC flag during compilation should resolve this issue. From our testing, enabling -fPIC does not introduce any compatibility issues with existing use cases.

Would it be possible to include the -fPIC flag by default in the compilation process for .a files? This change would significantly improve the library’s usability in scenarios like ours and prevent downstream conflicts.

Thank you for considering this request. Please let us know if you need any additional details or assistance to implement this change.

@PureWhiteWu PureWhiteWu changed the title Request to Add -fPIC Flag in .a File Compilation Request to Add -fPIC Flag in .a File Compilation Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant