Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variadic range() function #29

Open
jmbothe opened this issue Jan 25, 2018 · 7 comments
Open

variadic range() function #29

jmbothe opened this issue Jan 25, 2018 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@jmbothe
Copy link
Collaborator

jmbothe commented Jan 25, 2018

Requesting help creating a variadic range() function that takes a series of numbers and returns the difference between the largest and smallest values

@jhowardjr jhowardjr added the help wanted Extra attention is needed label Jan 25, 2018
@khusbuchandra
Copy link
Contributor

Is this supposed to be opposite of what lodash range function does? Naming it range might create a confusion i think, as the function intends to do is find the maximum difference. How about maxDifference() or something on that line?

@jmbothe
Copy link
Collaborator Author

jmbothe commented Jan 27, 2018

ahhh yes, good point. And it brings up a lot of other good points. I guess it depends on any given user's familiarity with lodash, and whether we consider namespacing as significant enough differentiation. Within the context of statistics, range is definitely the correct term to use, so I wouldn't be quick to give lodash a monopoly on the term just because its one of the most popular libraries out there (especially since this library is mostly for edifying purposes). But for clarity's sake, we might consider prefixing any arithmetic/statistical method with get (for example, getRange() or getAverage()). another option might be further namespacing like variadic.stats.range().

just spitballing right now. thoughts?

@khusbuchandra
Copy link
Contributor

Now I understand where you are coming from and agree to it. I like the idea of namespacing, lets have a standard and have it across.

@jhowardjr
Copy link
Member

👍namespacing would be the cleaner implementation.

@jmbothe
Copy link
Collaborator Author

jmbothe commented Jan 28, 2018

So I've never really been involved in something like this before, but I guess the collaborators of the repo would need to do some planning ahead to figure out what categories of functions they expect to have and decide on a namespacing conventions ahead of time. Or else, just move forward and introduce namespaces as needed. Of course the latter would mean making breaking changes every time you introduce a new namespace

@someyoungideas
Copy link
Contributor

I'd be glad to take this item if it is still available.

@jhowardjr
Copy link
Member

jhowardjr commented Mar 10, 2018

@someyoungideas actually someone just submitted a pull request for this one. If you look in the readme there are some other opportunities that might interest you. If you find one just create an issue for it.

@jhowardjr jhowardjr reopened this Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants