Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable key_transform option for all adapters #32

Open
pmackay opened this issue May 10, 2020 · 2 comments
Open

Enable key_transform option for all adapters #32

pmackay opened this issue May 10, 2020 · 2 comments

Comments

@pmackay
Copy link

pmackay commented May 10, 2020

It would be super helpful if the key_transform option could be applied generically across adapters (similar to how documented here. Currently the JSON::API adapter has this but the AMS one does not.
@pmackay
Copy link
Author

pmackay commented Aug 6, 2020

@vasilakisfil any thoughts on whether this would be a valid addition?

@vasilakisfil
Copy link
Owner

I am not sure if that fits in the Document/fields responsibility. What we can do for now, is to specify some options that every adapter should include. I can work on the AMS adapter this weekend to bring in this functionality and write some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmackay @vasilakisfil