From d0591fd57abdb17aedfa383f9b9127ce89dc6eeb Mon Sep 17 00:00:00 2001 From: Dom Del Nano Date: Sun, 20 Aug 2023 21:29:26 -0700 Subject: [PATCH] Minor comment edits --- client/network.go | 3 +++ xoa/resource_xenorchestra_bonded_network_test.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/client/network.go b/client/network.go index 639c24ea..72cef4e8 100644 --- a/client/network.go +++ b/client/network.go @@ -49,6 +49,9 @@ func (net Network) Compare(obj interface{}) bool { type CreateNetworkRequest struct { // The first set of members are shared between bonded and non bonded networks // These should be kept in sync with the CreateBondedNetworkRequest struct + // Refactoring these fields to an embedded struct means that the caller must + // know the embedded structs existance. Since the list is relatively small + // this was deemed a more appropriate tradeoff to make the API nicer. Automatic bool `mapstructure:"automatic"` DefaultIsLocked bool `mapstructure:"defaultIsLocked"` Pool string `mapstructure:"pool"` diff --git a/xoa/resource_xenorchestra_bonded_network_test.go b/xoa/resource_xenorchestra_bonded_network_test.go index e347ea70..4a7b60fa 100644 --- a/xoa/resource_xenorchestra_bonded_network_test.go +++ b/xoa/resource_xenorchestra_bonded_network_test.go @@ -28,7 +28,7 @@ func TestAccXOBondedNetwork_createAndPlanWithOmittedPIF(t *testing.T) { resource.TestCheckResourceAttrSet(resourceName, "mtu")), }, { - // Asserting that pif_ids was set in the previous set failed. This + // Asserting that pif_ids was set in the previous step failed. This // second step is to verify that even though it's not persisted in the // state that it still correctly detects changes to the resource when // the pif_ids argument is modified.