Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TWEAK] Rename either the compiler_id or built-in toolchain for gcc #128

Open
maxtruxa opened this issue May 17, 2022 · 1 comment
Open

[TWEAK] Rename either the compiler_id or built-in toolchain for gcc #128

maxtruxa opened this issue May 17, 2022 · 1 comment
Assignees
@vector-of-bool
Labels
enhancement New feature or request
Milestone
On-Deck

Comments

@maxtruxa
Copy link
Contributor

Existing Behavior and Potential Problems
Right now the compiler_id and built-in toolchain name for clang and msvc match, but for gcc they don't: The compiler_id is gnu while the built-in toolchain is called gcc. IMO this is confusing for no reason.

Describe Alternatives
Rename the compiler_id to gcc.
@maxtruxa maxtruxa added the enhancement New feature or request label May 17, 2022
@vector-of-bool
Copy link
Owner

I had not considered this discrepancy. Toolchains are probably going to see a significant refactor eventually. For now, I think the easiest and most compatible change is to accept both gcc and gnu for the compiler_id.

@vector-of-bool vector-of-bool added this to the On-Deck milestone Jun 17, 2022
@vector-of-bool vector-of-bool self-assigned this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vector-of-bool vector-of-bool

Labels
enhancement New feature or request
Projects
None yet
Milestone
On-Deck
Development

No branches or pull requests
2 participants
@maxtruxa @vector-of-bool