custom fields not hydrated (?) before publishing product.updated event

[jezzzm]

Is your feature request related to a problem? Please describe.
I realised I had a bug in my code - I was checking product custom fields before deciding to add that product to a job queue or not. what i missed was that the custom fields objects was just a whole bunch of nulls.

i'm not sure, but i believe the translatableSaver isn't hydrating (for want of a better word) the updatedProduct with its custom fields before publishing the update event.

vendure/packages/core/src/service/services/product.service.ts

Lines 248 to 268 in 7ea0710

	const updatedProduct = await this.translatableSaver.update({
	ctx,
	input,
	entityType: Product,
	translationType: ProductTranslation,
	beforeSave: async p => {
	if (input.facetValueIds) {
	const facetValuesInOtherChannels = product.facetValues.filter(fv =>
	fv.channels.every(channel => !idsAreEqual(channel.id, ctx.channelId)),
	);
	p.facetValues = [
	...facetValuesInOtherChannels,
	...(await this.facetValueService.findByIds(ctx, input.facetValueIds)),
	];
	}
	await this.assetService.updateFeaturedAsset(ctx, p, input);
	await this.assetService.updateEntityAssets(ctx, p, input);
	},
	});
	await this.customFieldRelationService.updateRelations(ctx, Product, input, updatedProduct);
	await this.eventBus.publish(new ProductEvent(ctx, updatedProduct, 'updated', input));

Describe the solution you'd like
the translatableSaver to populate custom fields before returning the product entity.

Describe alternatives you've considered
i have worked around this by making another request to get the whole product by id (including custom fields), but it'd be great to not have to do that.

Additional context

[michaelbromley]

Thanks for the report. I was at first thinking this was referring to relation-type custom fields, but I see most of your custom fields are primitive types. So it looks like a bug.