Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for mac's command key for selection manager #3315

Open
wants to merge 2 commits into
base: minor
Choose a base branch
from

Conversation

rein1410
Copy link
Contributor

@rein1410 rein1410 commented Jan 13, 2025

Description

Selection manager was missing support for multiple selection with the mac's command key, causing Mac users unable to select images one by one. since holding control on Mac opens the right click menu on chrome based browsers.

Breaking changes

No

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 13, 2025 8:01am

Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@rein1410 rein1410 changed the title fix: add support for command key for selection manager fix: add support for mac's control key for selection manager Jan 13, 2025
@rein1410 rein1410 changed the title fix: add support for mac's control key for selection manager fix: add support for mac's command key for selection manager Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant