-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particles not disappearing from screen #34
Comments
Specifically, the fadeout logic multiplies the particle's alpha by 0.96 each frame, which means it doesn't converge on zero generally, and throttling of RequestAnimationFrame due to load would presumably make this worse |
Nope, I'm wrong. What's actually going on is that the list of particles is cleared at the end of the frame draw if they're low enough opacity, but the check at the start of the next draw skips clearing the canvas if there are no particles, and so leaves the last frame drawn |
Any chance this will be fixed? |
I'm having the same issue... |
Ditto; same problem. Windows 10 1803, FWIW. |
This seems to be theme-specific, the particles do disappear with the default one. |
Any update on this? |
Oh, it's around 2 years Update: It exists on Mac, 1.1.1 , with Hyper 3.0.0-canary.8 (canary) |
I think this is fixed with the last release (v1.1.1). Please update and try to reproduce |
Thank you for your feedback! 🙏 |
Im having same issue... |
I've fixed it by adding |
You could open a PR ;) |
I took the liberty to open a new Pull Request for this, just to save people the hassle of rebasing. Also I made the cutoff point a variable instead of just 0.1, so it's a bit more human-readable. Other than that it is functionally identical to @rfgamaral's PR from two years ago. |
2 pull requests, 5 years, simple issue still unresolved, yet another tragedy of the commons. |
I think they did actually merge #75 which addressed the same problem |
The issue still persist because they didn't push the fix to npm. If I put the index.js file from the repo to ~/.hyper_plugins/node_modules/hyperterminal/ this issue get fixed |
i have the same issue |
The text was updated successfully, but these errors were encountered: