Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particles not disappearing from screen #34

Open
ghost opened this issue Apr 2, 2017 · 20 comments · May be fixed by #71
Open

Particles not disappearing from screen #34

ghost opened this issue Apr 2, 2017 · 20 comments · May be fixed by #71

Comments

@ghost
Copy link

ghost commented Apr 2, 2017

2017-04-01 21 36 34

@joshclow
Copy link

Specifically, the fadeout logic multiplies the particle's alpha by 0.96 each frame, which means it doesn't converge on zero generally, and throttling of RequestAnimationFrame due to load would presumably make this worse

@joshclow
Copy link

Nope, I'm wrong. What's actually going on is that the list of particles is cleared at the end of the frame draw if they're low enough opacity, but the check at the start of the next draw skips clearing the canvas if there are no particles, and so leaves the last frame drawn

@jacksonhvisuals
Copy link

Any chance this will be fixed?

@CyanoKobalamyne
Copy link

I'm having the same issue...

@Ugenx
Copy link

Ugenx commented Aug 15, 2018

Ditto; same problem. Windows 10 1803, FWIW.

@CyanoKobalamyne
Copy link

This seems to be theme-specific, the particles do disappear with the default one.

@azizuysal
Copy link

Any update on this?

@linonetwo
Copy link

linonetwo commented Feb 14, 2019

Oh, it's around 2 years


Update:

It exists on Mac, 1.1.1 , with Hyper 3.0.0-canary.8 (canary)

@chabou
Copy link
Collaborator

chabou commented Feb 14, 2019

I think this is fixed with the last release (v1.1.1). Please update and try to reproduce

@fabio-oliveira-efeo
Copy link

fabio-oliveira-efeo commented Feb 14, 2019

The problem persists for me.
hyperpower
hyperpower1 1 1

@chabou
Copy link
Collaborator

chabou commented Feb 14, 2019

Thank you for your feedback! 🙏

@crstnmac
Copy link

Im having same issue...

@bernaferrari
Copy link

Same issue
image

@danielhuang
Copy link

I've fixed it by adding if (particle.alpha < 0.1) particle.alpha = 0; in _drawFrame.

@rfgamaral
Copy link

I've fixed it by adding if (particle.alpha < 0.1) particle.alpha = 0; in _drawFrame.

You could open a PR ;)

@danielhuang danielhuang linked a pull request Jul 9, 2019 that will close this issue
@lymanjohnson
Copy link

I took the liberty to open a new Pull Request for this, just to save people the hassle of rebasing. Also I made the cutoff point a variable instead of just 0.1, so it's a bit more human-readable. Other than that it is functionally identical to @rfgamaral's PR from two years ago.

#83

@digitaljhelms
Copy link

2 pull requests, 5 years, simple issue still unresolved, yet another tragedy of the commons.

@lymanjohnson
Copy link

2 pull requests, 5 years, simple issue still unresolved, yet another tragedy of the commons.

I think they did actually merge #75 which addressed the same problem

@siddharthroy12
Copy link

siddharthroy12 commented May 13, 2023

The issue still persist because they didn't push the fix to npm. If I put the index.js file from the repo to ~/.hyper_plugins/node_modules/hyperterminal/ this issue get fixed

@Zackariyya
Copy link

i have the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.