Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci tests fail consistently in Windows (Node and Rust) #1407

Closed
ibc opened this issue Jun 10, 2024 · 10 comments
Closed

Ci tests fail consistently in Windows (Node and Rust) #1407

ibc opened this issue Jun 10, 2024 · 10 comments
Assignees
Labels
Milestone

Comments

@ibc
Copy link
Member

ibc commented Jun 10, 2024

Nothing changed in related source code, it's just that CI tests in Windows (Node and Rust) started failing, so this is probably due to some change/update in the Windows version or its tools in CI hosts.

@ibc
Copy link
Member Author

ibc commented Jun 15, 2024

Good news @nazar-pc! This issue auto-fixed itself.

@ibc ibc closed this as completed Jun 15, 2024
@nazar-pc
Copy link
Collaborator

Good news, sure, but do you have an idea why? 😂

@ibc
Copy link
Member Author

ibc commented Jun 15, 2024

Good news, sure, but do you have an idea why? 😂

We don't know why it broke and we don't know why it auto-fixed itself. So we are good (meaning that it will eventually happen again and we'll have no idea, but that's ok).

@satoren
Copy link
Contributor

satoren commented Jun 16, 2024

@ibc
Since the test code previously contained undefined behavior, it is not surprising that errors occur depending on the randomness and environment. Why not run tests with CI with various sanitizers enabled?

@ibc
Copy link
Member Author

ibc commented Jun 17, 2024

@ibc Since the test code previously contained undefined behavior, it is not surprising that errors occur depending on the randomness and environment. Why not run tests with CI with various sanitizers enabled?

You mean compiling mediasoup-worker with address sanitizer and so on and run Node and Rust tests that way?

@satoren
Copy link
Contributor

satoren commented Jun 17, 2024

Yes.

We can also confirm that the test fails when run with address sanitizer enabled in Node tests.
https://github.com/satoren/mediasoup/actions/runs/9545217751/job/26305515808?pr=2

You can try this by simply setting a few environment variables.
https://github.com/satoren/mediasoup/pull/2/files#diff-8ef8d7b717d737ed620a4153e34a3d1f8240b4544d09ccd7d284b6ebfa594d35R21

@satoren
Copy link
Contributor

satoren commented Jun 17, 2024

It seems that sanitizer interferes with SIGNAL, so the error may be due to that.

@ibc
Copy link
Member Author

ibc commented Jun 17, 2024

asan_option: 'detect_leaks=0' # Disable leak detection because detect memory leaks in flatbuffers tool.

Which memory leak issue in flatbuffers?

It seems that sanitizer interferes with SIGNAL, so the error may be due to that.

Then we should include some env in matrix entries using sanitizer to avoid running that test.

@satoren
Copy link
Contributor

satoren commented Jun 18, 2024

Which memory leak issue in flatbuffers?

The flatc to be used for the build. This is really noise.
https://github.com/satoren/mediasoup/actions/runs/9540178305/job/26291556482#step:5:1857

@ibc
Copy link
Member Author

ibc commented Jun 28, 2024

Related: #1416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants