Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle eagerly evaluated Results in actor methods #149

Open
eureka-cpu opened this issue May 2, 2024 · 1 comment
Open

Handle eagerly evaluated Results in actor methods #149

eureka-cpu opened this issue May 2, 2024 · 1 comment
Labels
code quality Improves either readability of code, or organizational structure good first issue Good for newcomers

Comments

@eureka-cpu
Copy link
Collaborator

Unwinding errors in actor methods can cause an actor to fail, which removes it from the ractor registry. We want to handle all possible error scenarios to prevent actors from failing.
@eureka-cpu eureka-cpu added the code quality Improves either readability of code, or organizational structure label May 2, 2024
@eureka-cpu eureka-cpu self-assigned this May 2, 2024
@eureka-cpu eureka-cpu mentioned this issue May 3, 2024
Merged
@eureka-cpu eureka-cpu removed their assignment Jul 8, 2024
@eureka-cpu eureka-cpu added the good first issue Good for newcomers label Jul 8, 2024
@eureka-cpu
Copy link
Collaborator Author

To further elaborate, the only time the network should panic is when an environment variable is missing. Actor panics can still happen but are caught and restarted automatically by the actor manager, but that doesn't mean we should just allow those panics to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improves either readability of code, or organizational structure good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eureka-cpu