From 33c89bdd14e46861fd8fdab8360189f0eeceba3f Mon Sep 17 00:00:00 2001 From: Martin Polden Date: Thu, 23 Jan 2025 14:43:15 +0100 Subject: [PATCH] Remove unnecessary newline --- client/go/internal/cli/cmd/deploy.go | 1 - client/go/internal/cli/cmd/deploy_test.go | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/client/go/internal/cli/cmd/deploy.go b/client/go/internal/cli/cmd/deploy.go index 6f7c5bdc763..6305e1a4a2f 100644 --- a/client/go/internal/cli/cmd/deploy.go +++ b/client/go/internal/cli/cmd/deploy.go @@ -94,7 +94,6 @@ $ vespa deploy -t cloud -z perf.aws-us-east-1c`, } return err } - log.Println() if opts.Target.IsCloud() { cli.printSuccess("Triggered deployment of ", color.CyanString("'"+pkg.Path+"'"), " with run ID ", color.CyanString(strconv.FormatInt(result.ID, 10))) } else { diff --git a/client/go/internal/cli/cmd/deploy_test.go b/client/go/internal/cli/cmd/deploy_test.go index b1e730a926a..3fa0849fbe4 100644 --- a/client/go/internal/cli/cmd/deploy_test.go +++ b/client/go/internal/cli/cmd/deploy_test.go @@ -167,7 +167,7 @@ func TestDeployWait(t *testing.T) { mockServiceStatus(client, "foo") // Look up services assert.Nil(t, cli.Run("deploy", "--wait=3", pkg)) assert.Equal(t, - "\nSuccess: Deployed '"+pkg+"' with session ID 1\n", + "Success: Deployed '"+pkg+"' with session ID 1\n", stdout.String()) } @@ -194,7 +194,7 @@ func TestDeployZipWithURLTargetArgument(t *testing.T) { cli.httpClient = client assert.Nil(t, cli.Run(arguments...)) assert.Equal(t, - "\nSuccess: Deployed '"+applicationPackage+"' with session ID 0\n", + "Success: Deployed '"+applicationPackage+"' with session ID 0\n", stdout.String()) assertDeployRequestMade("http://target:19071", client, t) } @@ -234,7 +234,7 @@ func TestDeployIncludesExpectedFiles(t *testing.T) { assert.Nil(t, cli.Run("deploy", "--wait=0", "testdata/applications/withSource")) applicationPackage := "testdata/applications/withSource/src/main/application" assert.Equal(t, - "\nSuccess: Deployed '"+applicationPackage+"' with session ID 0\n", + "Success: Deployed '"+applicationPackage+"' with session ID 0\n", stdout.String()) zipName := filepath.Join(t.TempDir(), "tmp.zip") @@ -296,7 +296,7 @@ func assertDeploy(applicationPackage string, arguments []string, t *testing.T) { cli.httpClient = client assert.Nil(t, cli.Run(arguments...)) assert.Equal(t, - "\nSuccess: Deployed '"+applicationPackage+"' with session ID 0\n", + "Success: Deployed '"+applicationPackage+"' with session ID 0\n", stdout.String()) assertDeployRequestMade("http://127.0.0.1:19071", client, t) }