Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize error codes returned from the native module #11

Open
alexrp opened this issue Jul 4, 2022 · 0 comments
Open

Sanitize error codes returned from the native module #11

alexrp opened this issue Jul 4, 2022 · 0 comments
Assignees
@alexrp
Labels
area: injection Issues related to the assembly injection APIs. area: module Issues related to the injected native module. state: approved Enhancements and tasks that have been approved.
Milestone
v3.0

Comments

@alexrp
Copy link
Member

alexrp commented Jul 4, 2022

They're an arbitrary mess currently. A more disciplined error code format would allow the injector to throw more helpful exceptions when errors occur.

We should perhaps standardize on the GetLastError format: https://docs.microsoft.com/en-us/windows/win32/api/errhandlingapi/nf-errhandlingapi-getlasterror#remarks
@alexrp alexrp added state: approved Enhancements and tasks that have been approved. type: feature area: module Issues related to the injected native module. area: injection Issues related to the assembly injection APIs. labels Jul 4, 2022
@alexrp alexrp added this to the v2.0 milestone Jul 4, 2022
@alexrp alexrp self-assigned this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexrp alexrp

Labels
area: injection Issues related to the assembly injection APIs. area: module Issues related to the injected native module. state: approved Enhancements and tasks that have been approved.
Milestone
v3.0
Development

No branches or pull requests
1 participant
@alexrp