Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Considering using Opentelemetry Naming Conventions #200

Open
markhildreth-gravity opened this issue Jul 5, 2023 · 1 comment
Open

Considering using Opentelemetry Naming Conventions #200

markhildreth-gravity opened this issue Jul 5, 2023 · 1 comment
Labels
breaking

Comments

@markhildreth-gravity
Copy link

Currently, gue attaches some span attribute when a job is being run. This is great, although the attributes do not match OpenTelemetry naming conventions.

For each multi-word dot-delimited component of the attribute name separate the words by underscores (i.e. use snake_case). For example http.response.status_code denotes the status code in the http namespace.

Thus job-id would be better named as job_id, etc.
@vgarvardt
Copy link
Owner

This is breaking change. I'll do it together with other BCs for the new major version once it is planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vgarvardt @markhildreth-gravity