Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by 1 error on end position bounds check #449

Open
adamnovak opened this issue Jun 14, 2024 · 1 comment
Open

Off by 1 error on end position bounds check #449

adamnovak opened this issue Jun 14, 2024 · 1 comment

Comments

@adamnovak
Copy link
Member

I loaded up a graph with a 142 bp path in it. I asked to see that path from 1 to 142. I was told that that ran off the end of the 142 bp path, and I had to use 1-141 instead.

We should accept 1-based inclusive ranges that end on the last base of the path.

@adamnovak adamnovak converted this from a draft issue Jun 14, 2024
@adamnovak adamnovak moved this from Todo to In Progress in Tube Map/Lancet Integration Jun 14, 2024
@adamnovak
Copy link
Member Author

Really the problem is that vg chunk and BED both currently use 0-based coordinates, but we want the UI for the tube map to use 1-based coordinates like the genome browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant