Unsound code related to subsystem reference counting

[antonilol]

I also suspect that EventSubsystem::sdl is unsound, because it is Sync this can be called from any thread, not only the main thread, effectively copying instances of the Sdl struct to other threads.

Originally posted by @antonilol in #102 (comment)

Instances of the Sdl struct should not be sent between threads (it is !Send)

[antonilol]

A possible solution is removing https://github.com/vhspace/sdl3-rs/blob/master/src/sdl3/sdl.rs#L260-L272. Does this method add any value? Sdl contexts can be cloned already if needed.

[revmischa]

A possible solution is removing https://github.com/vhspace/sdl3-rs/blob/master/src/sdl3/sdl.rs#L260-L272. Does this method add any value? Sdl contexts can be cloned already if needed.

I don't know if it's used at all, maybe!

[antonilol]

It does not seem to be used in the crate itself, but it is public API, so is it okay to remove it in the next breaking change?

[revmischa]

Yeah I'm not calling anything super stable yet