Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvement: Make an SdlError type that implements Error #32

Open
jgcodes2020 opened this issue Oct 22, 2024 · 2 comments
Open

API improvement: Make an SdlError type that implements Error #32

jgcodes2020 opened this issue Oct 22, 2024 · 2 comments

Comments

@jgcodes2020
Copy link
Contributor

This breaks pretty much every function, but has the upside of playing nicer with the rest of the ecosystem, allowing SDL errors to be used as cause for other error types.

@revmischa
Copy link
Collaborator

Do you think this better belongs in this module or in sdl3-sys?

@Goldenbough44
Copy link
Contributor

It seems some adaptation of this issue pulled into crate 0.13.0.

But I found some compilation errors when:

  • when enabling hidapi feature
  • some tests and examples

because some parts not updated from String to Error struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants