Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to remove the crop function from Unsplash background image urls for better ultrawide support #516

Open
gwstorm opened this issue Dec 19, 2024 · 1 comment

Comments

@gwstorm
Copy link

gwstorm commented Dec 19, 2024

Is your feature request related to a problem? Please describe.
Currently, the unsplash background urls are formatted to crop the image to the height and width of the entire display from what I can see. Using a 32:9 monitor (5120x1440), it's rare to use a browser in full screen, so this leads to cropping a 32:9 chunk out of an image in a browser space that might be 1/2 to 1/3 that size in width which renders the background image fairly useless.

Describe the solution you'd like
I can see the value in cropping images, but it would seem like for the most part, your average "new tab and go" session could maybe benefit from either pulling the the window.innerWidth and window.innerHeight to fit the image to the browser or just have the option to prune &fit=crop from the url, which does make it fit in all widths just as well. This is currently only based on my personal use case, so I'm not sure if this would have any negative impacts.

Below is an example of a browser window that is about 1/3 the width of the screen using the default background image url and then a screenshot of only removing &fit=crop from the url. The version without crop also scales nicely when increasing and decreasing the browser window size

Screenshot-2024-12-19-01-41-44

Screenshot-2024-12-19-01-42-48

@victrme
Copy link
Owner

victrme commented Dec 20, 2024

Hi @gwstorm !

This is interesting. The reason why we use the device ratio is because images have to be preloaded to be that fast, which means we cannot crop based on the current window size.

We can maybe detect ultra wide monitors to avoid this kind of issue in the future, but cropping the image on-the-fly will not be possible !

We'll look into it for the next major update 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Planned
Development

No branches or pull requests

2 participants