-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to detect "com.microsoft.playready.recommendation" key system #167
Comments
Sounds like something that should be added. Unfortunately, I don't think anyone on the team likely has the bandwidth to tackle it currently. shaka-project/shaka-player#1495 had an interesting discussion on potentially using this if available even if users use |
Hey, @gkatsev. I'd like to make a PR to enable com.microsoft.playready.recommendation in videojs-contrib-eme. I came up with two possible ways this could be implemented. The first and easier way would be to simply add support for recognition of the The other possibility would be making some kind of smarter logic that would try to use the .recommendation automatically even if it's not specified in the config options of the player. E.g. the player is configured with vanilla playready and the contrib-eme would try to use the .recommendation playready version first and would fallback to vanilla playready afterwards if the .recommendation is not usable/supported by the os/browser. From what I've seen, this is the way they implemented the recommendation playready version in the shaka player. |
I opened PR with the simple solution. |
As per https://learn.microsoft.com/en-us/playready/overview/key-system-strings#available-key-system-strings , this is becoming a hot topic, because Microsoft is seemingly planning to get rid of legacy This means that videojs-based players might very likely stop working in Edge with PlayReady content unless these key systems are supported. The urgency for this task is therefore unfortunately increasing. |
Yep, this is on the radar. |
@misteroneill Can you please guess when you might find the time for this? |
Hi,
there is a key system
com.microsoft.playready.recommendation
recommended by Edge.Is there any planned support?
Or do you have any information?
Thanks! :)
The text was updated successfully, but these errors were encountered: