Disable EC2 Public Address lookup

[joshjdevl]

Is there a particular reason that when starting the storm cluster it is trying to access http://169.254.169.254/latest/meta-data/public-ipv4 ? This is the URL for EC2 instances to lookup their Public DNS address. Though why is it running automatically?

[yanhan]

Hi joshjdevl, the reason is that we were using Amazon EC2 instances to test out the storm-docker project and the public IP addresses of Amazon EC2 instances can only be accurately determined using the link you pasted. These 3 parts of the code should clarify things a little:

storm-docker/docker_python_helpers/docker_run.py

Line 166 in 6d33d21

ec2PublicIp = ec2_get_ip(public=True)

storm-docker/docker_python_helpers/docker_run.py

Line 169 in 6d33d21

ec2PrivateIp = ec2_get_ip(public=False)

storm-docker/docker_python_helpers/docker_run.py

Line 103 in 6d33d21

def ec2_get_ip(public=True):

You do have a point though - this is redundant when the machines involved are not on Amazon EC2. I could work on a patch to turn this on/off but the earliest I can start doing that will be this coming Monday.

Thanks for your interest in the storm-docker project =)

[joshjdevl]

Hi,

Thanks, an option would be nice. When I run this on a non ec2 machine it fails to startup. For now, I have deleted the lines of code.

[yanhan]

Hi joshjdevl, I've just committed a patch that partially resolves this issue: 2ca3a4f

Simple set the all_machines_are_ec2_instances in your config/storm-setup.yaml file to False. Omitting this key from config/storm-setup.yaml will default it to False as well. There is additional documentation in the config/storm-setup.yaml.sample file:

storm-docker/config/storm-setup.yaml.sample

Line 35 in 2ca3a4f

all_machines_are_ec2_instances: False

Tell me what you think of this change.

[joshjdevl]

Yes, this appears to work. Thanks!