Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason you are not using the original repos? #53

Open
itsthatguy opened this issue Oct 26, 2015 · 5 comments
Open

Is there a reason you are not using the original repos? #53

itsthatguy opened this issue Oct 26, 2015 · 5 comments

Comments

@itsthatguy
Copy link
Member

@mkaito It would be great to keep all of the repo history. I say just use all the original repositories.

@mkaito
Copy link
Contributor

mkaito commented Oct 26, 2015

I thought having things in one place was much easier to work with. Why was it in separate repos to begin with?

@mkaito
Copy link
Contributor

mkaito commented Oct 26, 2015

I could try to figure out a way to properly merge all the repos and keep commit history, then replay our new work on top. Will have to talk to @SailorOrion about that.

@itsthatguy
Copy link
Member Author

they were in separate repos because it made it easier to have multiple people doing releases of each individual addon, without causing conflicts and large sweeping breaking changes.

@itsthatguy
Copy link
Member Author

fwiw, at one point we had them in a single repo. But after a lot of trial, error, and discussion, we ultimately discovered the multiple repos were easier to tag versions, and make more frequent releases.

@mkaito
Copy link
Contributor

mkaito commented Oct 27, 2015

I see, that scenario makes a lot of sense. However, I don't think right now separate repositories are the best way forward.

I like working in a single repository, it hasn't caused me any issues, and it makes it easier for others to contribute. Changes that affect multiple modules but are related can go in a single commit and be better documented. We can use tags to offer convenient downloads (although I will want this on Curse at some point).

I'm going to look at merging the repositories properly, though, to keep commit history. If that doesn't work, I have no plans to delete the old repositories, and history will stay there either way. I will absolutely put everyone in the AUTHORS file. I've just been swamped with work lately, so haven't done much at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants