Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option: "local to window" options has getBuffer() method #267

Closed
Milly opened this issue Aug 28, 2024 · 1 comment · Fixed by #270
Closed

option: "local to window" options has getBuffer() method #267

Milly opened this issue Aug 28, 2024 · 1 comment · Fixed by #270
Labels
bug Something isn't working

Comments

@Milly
Copy link
Contributor

Milly commented Aug 28, 2024

  • Users may access options in an unintended way

    • For example, winfixwidth is meant to be window-local, but users can still access it through the getBuffer method.
  1. getBuffer() method exists even though winfixwidth etc are "local to window":
    This is an existing problem, it was there before this PR.

Originally posted by @Milly in #266 (comment)
@Milly Milly mentioned this issue Aug 28, 2024
Open
@Milly Milly added the bug Something isn't working label Aug 28, 2024
@Milly
Copy link
Contributor Author

Milly commented Aug 28, 2024

I'm working on this.

@Milly Milly mentioned this issue Aug 29, 2024
Merged
Milly added a commit that referenced this issue Aug 29, 2024
@Milly
👍 generate sub local scope option types
4525d17 
Fixes #267
Fixes some #268
@Milly Milly mentioned this issue Aug 29, 2024
Merged
@Milly Milly closed this as completed in 4cb6bde Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

👍 generate sub local scope option types vim-denops/deno-denops-std
1 participant
@Milly