Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication should return client not service #266

Closed
2 tasks
vinitkumar opened this issue Sep 6, 2017 · 1 comment
Closed
2 tasks

Authentication should return client not service #266

vinitkumar opened this issue Sep 6, 2017 · 1 comment
Assignees
@vinitkumar
Labels
bug enhancement

Comments

@vinitkumar
Copy link
Owner

After adding oauth2 support, a mistake was done and service instead of client is returned. This is the main reason for all the issue.

  • Refactor the code to return client instead of service.
  • Add more permissions in the scope when doing the auth call.
@vinitkumar vinitkumar self-assigned this Sep 6, 2017
@vinitkumar
Copy link
Owner Author

Fix this in #274. Closing this in favour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinitkumar vinitkumar

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vinitkumar