New --sample option does not seem to work as documented

[LuisBlanche]

Hi @vladkens ,
I am working on testing macmon for codecarbon cf mlco2/codecarbon#731

I have tried to use macmon with the -s option and it does not seem to work

I am on a M1 Macbook with Sequoia , upgraded macmon through brew upgrade macmon

WHAT WORKS :

macmon -V
-> macmon 0.4.2

macmon pipe 

-> {"temp":{"cpu_temp_avg":43.137943,"gpu_temp_avg":41.203922},"memory":{"ram_total":8589934592,"ram_usage":6924812288,"swap_total":5368709120,"swap_usage":4811980800},"ecpu_usage":[1139,0.10109444],"pcpu_usage":[2653,0.084456764],"gpu_usage":[396,0.11018046],"cpu_power":0.17914012,"gpu_power":0.1461393,"ane_power":0.0,"all_power":0.3252794,"sys_power":14.522659,"ram_power":0.0,"gpu_ram_power":0.0}
{"temp":{"cpu_temp_avg":44.217594,"gpu_temp_avg":40.891556}, ...

macmon -i 100
-> Green visual "top style" UX

-> {"temp":{"cpu_temp_avg":43.137943,"gpu_temp_avg":41.203922},"memory":{"ram_total":8589934592,"ram_usage":6924812288,"swap_total":5368709120,"swap_usage":4811980800},"ecpu_usage":[1139,0.10109444],"pcpu_usage":[2653,0.084456764],"gpu_usage":[396,0.11018046],"cpu_power":0.17914012,"gpu_power":0.1461393,"ane_power":0.0,"all_power":0.3252794,"sys_power":14.522659,"ram_power":0.0,"gpu_ram_power":0.0}
{"temp":{"cpu_temp_avg":44.217594,"gpu_temp_avg":40.891556}, ... STOPS AFTER 10 SAMPLES 

WHAT DOES NOT WORK :

using macmon pipe with both args :

macmon pipe -s 10 -i 500 | jq

-> error: unexpected argument '-i' found

-> Usage: macmon pipe [OPTIONS]

-> For more information, try '--help'.

using vanilla macmon with -s or --samples does not work

macmon -s 10

-> error: unexpected argument '-s' found

-> Usage: macmon [OPTIONS] [COMMAND]

-> For more information, try '--help'.

using macmon pipe with --interval doesn't work either :

macmon pipe -i 100
-> error: unexpected argument '-i' found

-> Usage: macmon pipe [OPTIONS]

-> For more information, try '--help'.

I think i've covered it , let me know if i can help !

[LuisBlanche]

EDIT : actually it seems that if I revert the order of args ie :
macmon -i 10 pipe -s 10 i get the intended result (ie 10 samples every 10 ms)

[vladkens]

Hi, @LuisBlanche.

-i is argument of macmon itself, and -s is argument of pipe subcommand.
So yes, correct syntax is macmon -i 10 pipe -s 10 and don't match the readme.
I will add fallback for -i to pipe command.

Also -i have minimal value as 100ms.

[vladkens]

@LuisBlanche

Released this fix in v0.5.0