-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC]: Enable stale bot for issues and PRs #9435
Comments
This commit adds configuration to run the `actions/stale` github action that closes stale issues and PRs. Further discussion is in the issue. Closes vllm-project#9435 Signed-off-by: Russell Bryant <[email protected]>
a draft PR showing sample configuration is here: #9436 |
This sounds good. Two comment:
|
I also support this, in the past I have spent many hours closing 100s of issues but it's not sustainable. I'm happy to be a reviewer on the PR to dial in the behaviour. |
There is also an argument to exempt specific labels like |
Drafts and issues with the I have mixed feelings on access to apply the |
As an interesting data point, here is the expected impact of the proposed config based on closing things after 120 days of inactivity:
|
I agree that a single comment is might make it a little too easy to keep an issue open forever. In the PR you have the workflow running on every comment, might that get expensive given the volume of comments received in this repo? @simon-mo would it be so bad if the only people able to add the |
Actually, how about instead of automatically adding Then people with triage and above can filter by this label and decide on a case by case basis? |
I like restricting it to those with triage access.
It's probably worth adding a page to the docs that covers all of this process info! I'll add that when the dust settles. |
Motivation.
There are currently >400 open PRs and ~1.7k open issues. Many of these are not active and could be closed. This problem is often more challenging in a very active and popular project like vLLM. GitHub provides an action to help automate this process.
https://github.com/actions/stale
By adopting this action, those with the time and interest in helping with issue triage or PR reviews will have an easier time ensuring their time is used most effectively.
Proposed Change.
I propose adopting
actions/stale
to automate the process of pruning the issue and PR queues of items with no activity.A sample policy would be something like this:
stale
label and leave a comment after an issue or PR has not had any activity within 90 days.The times are configurable. An interested party can leave a comment to reset the stale timer. Configuring a label that will tell the bot to ignore that issue or PR (like
keep-open
or something) is also possible.If there's interest, I am happy to do the PR for it. Agreeing on the policy is the harder and more important part.
Feedback Period.
No response
CC List.
No response
Any Other Things.
No response
Before submitting a new issue...
The text was updated successfully, but these errors were encountered: