Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LI expects on 200 for success -- shim passes third-party status #34

Open
flands opened this issue May 10, 2017 · 1 comment
Open

LI expects on 200 for success -- shim passes third-party status #34

flands opened this issue May 10, 2017 · 1 comment
Assignees
@ellieayla

Comments

@flands
Copy link
Collaborator

flands commented May 10, 2017

The shim returns the status code it received from the third-party destination (e.g. vRO). Turns out, LI requires a "200 OK" else it treats the response as a failure (e.g. "202 Accepted"). If LI rejects, then it retries to send the webhook, which means the same webhook may be processed multiple times. While this is a bug in LI, it can be solved in the shim. The request is to have the shim return "200 OK" for every 2xx status.
@johnddias
Copy link
Contributor

Hah! I always had this issue and could never figure it out!

sammcgeown added a commit to sammcgeown/webhook-shims that referenced this issue May 11, 2017
@sammcgeown
Fix for issue vmw-loginsight#34 - catch HTTP 2XX and return HTTP 200
bcdc233 
Fixes issue vmw-loginsight#34 where Log Insight expects HTTP 200 and retries the webhook if it doesn't receive it.
@sammcgeown sammcgeown mentioned this issue May 11, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellieayla ellieayla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flands @ellieayla @johnddias