Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-sequential unit_number and 64 disks per controller limit in samples/add_disk_to_vm.py #754

Open
nryc opened this issue Jan 31, 2025 · 0 comments

Comments

@nryc
Copy link

nryc commented Jan 31, 2025

Is your feature request related to a problem? Please describe.

Hi,

samples/add_disk_to_vm.py has currently two issues:

  • it loops through vm.config.hardware.device and increment the last unit_number found, but the last unit_number of vm.config.hardware.device isn't necessarily the greatest (unit_number aren't sequential),
  • the script sets a limit to 16 disks per controllers. Since vSphere 6.7, the limit is now 64 disks per controller.

Describe the solution you'd like

  • to address the non-sequential unit_number, we should take the max unit_number found and increment it, not the last one,
  • the limit for the number of disks per controller should be 64.

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant