Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/bump cometbft #1387

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat/bump cometbft #1387

wants to merge 3 commits into from

Conversation

altergui
Copy link
Contributor

  • go.mod: update cometbft from alpha.1 to rc.1
  • go get github.com/cometbft/[email protected]

mvdan and others added 2 commits September 10, 2024 16:05
The only breaking change is UpdateValidator, which is now either
a new constructor or a new struct type.
@altergui altergui linked an issue Sep 11, 2024 that may be closed by this pull request
GenFilePV and LoadOrGenFilePV needed to be adapted as well
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10828830788

Details

  • 14 of 20 (70.0%) changed or added relevant lines in 3 files are covered.
  • 61 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 62.173%

Changes Missing Coverage Covered Lines Changed/Added Lines %
vochain/apputils.go 2 4 50.0%
test/testcommon/vochain.go 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
vochain/indexer/indexer.go 2 76.36%
vochain/transaction/admin_tx.go 2 48.81%
vochain/transaction/transaction.go 2 58.57%
cmd/end2endtest/zkweighted.go 55 64.02%
Totals Coverage Status
Change from base Build 10791417569: -0.1%
Covered Lines: 16780
Relevant Lines: 26989

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CometBFT
3 participants