Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple ActionsWorker from StreamingConversation #655

Open
ajar98 opened this issue Jul 19, 2024 · 2 comments · May be fixed by #594
Open

Decouple ActionsWorker from StreamingConversation #655

ajar98 opened this issue Jul 19, 2024 · 2 comments · May be fixed by #594
Assignees

Comments

@ajar98
Copy link
Contributor

ajar98 commented Jul 19, 2024

Different types of AudioPipelines and various *PhoneConversations have actions that only work if they are attached specifically to those pipelines in question - we need to manually create ActionsWorker and pass them down into the lower level pipelines.

  • Also allows us to fix the problem currently being faced by folks in 0.1.113 where they can't use phone conversation actions without creating a bespoke ActionFactory
@ajar98 ajar98 linked a pull request Jul 19, 2024 that will close this issue
1 task
@ajar98 ajar98 self-assigned this Jul 19, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 18, 2024
Copy link

This issue has been automatically closed due to inactivity. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
@ajar98 ajar98 reopened this Oct 2, 2024
@github-actions github-actions bot removed the stale label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant