Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate way to eliminate duplicate source printing (volta list) #527

Open
chriskrycho opened this issue Aug 15, 2019 · 0 comments
Open

Investigate way to eliminate duplicate source printing (volta list) #527

chriskrycho opened this issue Aug 15, 2019 · 0 comments
Labels
code quality question

Comments

@chriskrycho
Copy link
Contributor

In #461, I introduced identical pretty-printing for Source and for the source of a Package—but since Package is distinct from Source, rather than simply having a source (in order to avoid having a bunch of Options and the possibility of invalid data), this code simply ends up duplicated. Is there a nice way to abstract over this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chriskrycho