Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Config class with fields #58

Open
plaos opened this issue Jun 10, 2022 · 0 comments
Open

Extend Config class with fields #58

plaos opened this issue Jun 10, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@plaos
Copy link
Contributor

plaos commented Jun 10, 2022

Currently, we read the config file into a raw dictionary. This leads to needing to explicitly extract fields by subscripting, in order to be ergonomic. Example: user = config["user"]. This isn't very nice, instead we should create fields on the Config class. This may involve restructuring the current pattern a bit, as the Config class today is mainly a namespace for setup and retrieval of the config file. The get_configuration method should probably be removed, in favor of just accessing the (new) fields directly, for instance.

@plaos plaos added enhancement New feature or request good first issue Good for newcomers labels Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant