From 3f991d175d12b2b658e9a3637ea3dc3fcd7ef696 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulysse=20G=C3=A9rard?= <thevoodoos@gmail.com>
Date: Tue, 16 Jan 2024 14:41:28 +0100
Subject: [PATCH] test: illustrate shortcomings of Merlin when lid have spaces
 or commentaries in them

---
 tests/test-dirs/occurrences/modules-in-path.t | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/tests/test-dirs/occurrences/modules-in-path.t b/tests/test-dirs/occurrences/modules-in-path.t
index 4a61393e8..95f9c56ee 100644
--- a/tests/test-dirs/occurrences/modules-in-path.t
+++ b/tests/test-dirs/occurrences/modules-in-path.t
@@ -1,8 +1,11 @@
   $ cat >main.ml <<'EOF'
   > module N = struct module M = struct let x = 42 end end
   > let () = print_int N.M.x
+  > let () = print_int N.M.(*comment*)x
   > EOF
 
+FIXME: longident with spaces will be highlighted incorrectly
+
   $ $MERLIN single occurrences -identifier-at 1:25 \
   > -filename main.ml <main.ml
   {
@@ -27,6 +30,16 @@
           "line": 2,
           "col": 22
         }
+      },
+      {
+        "start": {
+          "line": 3,
+          "col": 32
+        },
+        "end": {
+          "line": 3,
+          "col": 33
+        }
       }
     ],
     "notifications": []
@@ -56,7 +69,35 @@
           "line": 2,
           "col": 20
         }
+      },
+      {
+        "start": {
+          "line": 3,
+          "col": 30
+        },
+        "end": {
+          "line": 3,
+          "col": 31
+        }
       }
     ],
     "notifications": []
   }
+
+
+FIXME: reconstruct identifier does not handle correctly longidents with comments
+between components.
+  $ $MERLIN single occurrences -identifier-at 3:34 \
+  > -log-file - -log-section locate \
+  > -filename main.ml <main.ml
+  # 0.01 locate - reconstructed identifier
+  x
+  # 0.01 locate - from_string
+  inferred context: expression
+  # 0.01 locate - from_string
+  looking for the source of 'x' (prioritizing .ml files)
+  {
+    "class": "return",
+    "value": [],
+    "notifications": []
+  }