From 0c155b66b91131e257349cbaf1be376099b3dcd6 Mon Sep 17 00:00:00 2001 From: Marcello Seri Date: Mon, 18 Dec 2023 14:38:42 +0100 Subject: [PATCH 1/5] bechamel-js links against result Fails with ``` === ERROR while compiling bechamel-js.0.4.0 ==================================# context 2.2.0~alpha4~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository path ~/.opam/4.14/.opam-switch/build/bechamel-js.0.4.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p bechamel-js -j 255 exit-code 1 env-file ~/.opam/log/bechamel-js-7-ed3984.env output-file ~/.opam/log/bechamel-js-7-ed3984.out File "lib/js/dune", line 4, characters 33-39: 4 | (libraries bechamel fmt rresult result json-data-encoding jsonm)) ^^^^^^ Error: Library "result" not found. -> required by library "bechamel-js" in _build/default/lib/js -> required by _build/default/META.bechamel-js -> required by _build/install/default/lib/bechamel-js/META -> required by _build/default/bechamel-js.install -> required by alias install ``` Signed-off-by: Marcello Seri --- packages/bechamel-js/bechamel-js.0.3.0/opam | 1 + packages/bechamel-js/bechamel-js.0.4.0/opam | 1 + packages/bechamel-js/bechamel-js.0.5.0/opam | 1 + 3 files changed, 3 insertions(+) diff --git a/packages/bechamel-js/bechamel-js.0.3.0/opam b/packages/bechamel-js/bechamel-js.0.3.0/opam index 272e7702eee..fc0631ab7e0 100644 --- a/packages/bechamel-js/bechamel-js.0.3.0/opam +++ b/packages/bechamel-js/bechamel-js.0.3.0/opam @@ -20,6 +20,7 @@ depends: [ "dune" {>= "2.0.0"} "bechamel" {= version} "rresult" + "result" {>= "1.5"} "json-data-encoding" "jsonm" "fmt" {>= "0.9.0"} diff --git a/packages/bechamel-js/bechamel-js.0.4.0/opam b/packages/bechamel-js/bechamel-js.0.4.0/opam index 84c716ada26..60105b3c337 100644 --- a/packages/bechamel-js/bechamel-js.0.4.0/opam +++ b/packages/bechamel-js/bechamel-js.0.4.0/opam @@ -20,6 +20,7 @@ depends: [ "dune" {>= "2.0.0"} "bechamel" {= version} "rresult" + "result" {>= "1.5"} "json-data-encoding" "jsonm" "fmt" {>= "0.9.0"} diff --git a/packages/bechamel-js/bechamel-js.0.5.0/opam b/packages/bechamel-js/bechamel-js.0.5.0/opam index e221e563cda..2e06f997412 100644 --- a/packages/bechamel-js/bechamel-js.0.5.0/opam +++ b/packages/bechamel-js/bechamel-js.0.5.0/opam @@ -20,6 +20,7 @@ depends: [ "dune" {>= "2.0.0"} "bechamel" {= version} "rresult" + "result" {>= "1.5"} "json-data-encoding" "jsonm" "fmt" {>= "0.9.0"} From 123bd0a7116963ba5ea0fe7b079176dc077a40b1 Mon Sep 17 00:00:00 2001 From: Marcello Seri Date: Mon, 18 Dec 2023 14:42:19 +0100 Subject: [PATCH 2/5] some session-* packages require the result library They explicitly link against it. Failures are all similar and look like the following ``` === ERROR while compiling session-cookie-lwt.0.1.8 ===========================# context 2.2.0~alpha4~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository path ~/.opam/4.14/.opam-switch/build/session-cookie-lwt.0.1.8 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p session-cookie-lwt -j 255 @install exit-code 1 env-file ~/.opam/log/session-cookie-lwt-7-f8b6e2.env output-file ~/.opam/log/session-cookie-lwt-7-f8b6e2.out File "session-cookie-lwt/dune", line 4, characters 16-22: 4 | (libraries lwt result session-cookie)) ^^^^^^ Error: Library "result" not found. -> required by library "session-cookie-lwt" in _build/default/session-cookie-lwt -> required by _build/default/META.session-cookie-lwt -> required by _build/install/default/lib/session-cookie-lwt/META -> required by _build/default/session-cookie-lwt.install -> required by alias install ``` Fixes https://github.com/ocaml/opam-repository/issues/24944 Signed-off-by: Marcello Seri --- packages/session-cohttp-async/session-cohttp-async.0.4.0/opam | 1 + packages/session-cohttp-async/session-cohttp-async.0.4.1/opam | 1 + packages/session-cohttp-lwt/session-cohttp-lwt.0.4.0/opam | 1 + packages/session-cohttp-lwt/session-cohttp-lwt.0.4.1/opam | 1 + packages/session-cookie-async/session-cookie-async.0.1.8/opam | 1 + packages/session-cookie-lwt/session-cookie-lwt.0.1.8/opam | 1 + 6 files changed, 6 insertions(+) diff --git a/packages/session-cohttp-async/session-cohttp-async.0.4.0/opam b/packages/session-cohttp-async/session-cohttp-async.0.4.0/opam index c48f175b738..f6fa87fa64d 100644 --- a/packages/session-cohttp-async/session-cohttp-async.0.4.0/opam +++ b/packages/session-cohttp-async/session-cohttp-async.0.4.0/opam @@ -15,6 +15,7 @@ depends: [ "ocaml" "jbuilder" {>= "1.0+beta9"} "session-cohttp" + "result" {>= "1.5"} "cohttp-async" "async" "base-threads" diff --git a/packages/session-cohttp-async/session-cohttp-async.0.4.1/opam b/packages/session-cohttp-async/session-cohttp-async.0.4.1/opam index ff20a6575dd..ffcc508005b 100644 --- a/packages/session-cohttp-async/session-cohttp-async.0.4.1/opam +++ b/packages/session-cohttp-async/session-cohttp-async.0.4.1/opam @@ -12,6 +12,7 @@ depends: [ "cohttp-async" "async" "base-threads" + "result" {>= "1.5"} ] build: [ ["dune" "subst"] {dev} diff --git a/packages/session-cohttp-lwt/session-cohttp-lwt.0.4.0/opam b/packages/session-cohttp-lwt/session-cohttp-lwt.0.4.0/opam index 5392723ff2b..41d34e0e5d3 100644 --- a/packages/session-cohttp-lwt/session-cohttp-lwt.0.4.0/opam +++ b/packages/session-cohttp-lwt/session-cohttp-lwt.0.4.0/opam @@ -17,6 +17,7 @@ depends: [ "session-cohttp" "cohttp-lwt" "lwt" + "result" {>= "1.5"} ] synopsis: "A session manager for your everyday needs - Cohttp-specific support for lwt" diff --git a/packages/session-cohttp-lwt/session-cohttp-lwt.0.4.1/opam b/packages/session-cohttp-lwt/session-cohttp-lwt.0.4.1/opam index ac30f0abffe..26f81f10cc2 100644 --- a/packages/session-cohttp-lwt/session-cohttp-lwt.0.4.1/opam +++ b/packages/session-cohttp-lwt/session-cohttp-lwt.0.4.1/opam @@ -11,6 +11,7 @@ depends: [ "session-cohttp" "cohttp-lwt" "lwt" + "result" {>= "1.5"} ] build: [ ["dune" "subst"] {dev} diff --git a/packages/session-cookie-async/session-cookie-async.0.1.8/opam b/packages/session-cookie-async/session-cookie-async.0.1.8/opam index 2f0e57d1b55..6dc3f8ebafd 100644 --- a/packages/session-cookie-async/session-cookie-async.0.1.8/opam +++ b/packages/session-cookie-async/session-cookie-async.0.1.8/opam @@ -13,6 +13,7 @@ depends: [ "ocaml" {>= "4.07.0"} "session-cookie" {= version} "async" + "result" {>= "1.5"} "alcotest" {with-test} "junit" {with-test} "junit_alcotest" {with-test} diff --git a/packages/session-cookie-lwt/session-cookie-lwt.0.1.8/opam b/packages/session-cookie-lwt/session-cookie-lwt.0.1.8/opam index 8b9887ce4b1..4abf78fab2c 100644 --- a/packages/session-cookie-lwt/session-cookie-lwt.0.1.8/opam +++ b/packages/session-cookie-lwt/session-cookie-lwt.0.1.8/opam @@ -13,6 +13,7 @@ depends: [ "ocaml" {>= "4.07.0"} "session-cookie" {= version} "lwt" + "result" {>= "1.5"} "base" {with-test} "alcotest" {with-test} "junit" {with-test} From 0b3c8b3c1548ed582fb68baae6a0f04c4b863a48 Mon Sep 17 00:00:00 2001 From: Marcello Seri Date: Mon, 18 Dec 2023 15:25:47 +0100 Subject: [PATCH 3/5] piaf 0.1.0 requires result It vendors some libraries that require it: ``` === ERROR while compiling piaf.0.1.0 =========================================# context 2.2.0~alpha3 | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository path ~/.opam/4.14/.opam-switch/build/piaf.0.1.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p piaf -j 71 exit-code 1 env-file ~/.opam/log/piaf-7-ccfb59.env output-file ~/.opam/log/piaf-7-ccfb59.out File "vendor/dune", line 95, characters 3-9: 95 | result ^^^^^^ Error: Library "result" not found. -> required by library "piaf.multipart_form" in _build/default/vendor/multipart_form/lib -> required by _build/default/META.piaf -> required by _build/install/default/lib/piaf/META -> required by _build/default/piaf.install -> required by alias install File "vendor/dune", line 60, characters 3-9: 60 | result ^^^^^^ Error: Library "result" not found. -> required by library "piaf.h2" in _build/default/vendor/ocaml-h2/lib -> required by _build/default/META.piaf -> required by _build/install/default/lib/piaf/META -> required by _build/default/piaf.install -> required by alias install File "vendor/dune", line 8, characters 42-48: 8 | (libraries angstrom faraday bigstringaf result))) ^^^^^^ Error: Library "result" not found. -> required by library "piaf.httpaf" in _build/default/vendor/httpaf/lib -> required by _build/default/META.piaf -> required by _build/install/default/lib/piaf/META -> required by _build/default/piaf.install -> required by alias install ``` Signed-off-by: Marcello Seri --- packages/piaf/piaf.0.1.0/opam | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/piaf/piaf.0.1.0/opam b/packages/piaf/piaf.0.1.0/opam index f4ac67d16c9..d9aff3c8e06 100644 --- a/packages/piaf/piaf.0.1.0/opam +++ b/packages/piaf/piaf.0.1.0/opam @@ -24,6 +24,7 @@ depends: [ "mrmime" {>= "0.3.2" & < "0.4.0"} "pecu" "psq" + "result" "uri" "magic-mime" "gluten-lwt-unix" From b593f085733b6228f7035db296d353548016429f Mon Sep 17 00:00:00 2001 From: Marcello Seri Date: Mon, 18 Dec 2023 15:28:26 +0100 Subject: [PATCH 4/5] multipart_form requires result versions 0.1.0, 0.4.1 and 0.5.0 are failing with ``` === ERROR while compiling multipart_form.0.1.0 ===============================# context 2.2.0~alpha3 | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository path ~/.opam/4.14/.opam-switch/build/multipart_form.0.1.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p multipart_form -j 255 exit-code 1 env-file ~/.opam/log/multipart_form-7-0e3ea2.env output-file ~/.opam/log/multipart_form-7-0e3ea2.out File "lib/dune", line 5, characters 8-14: 5 | pecu result rresult uutf fmt angstrom)) ^^^^^^ Error: Library "result" not found. -> required by library "multipart_form" in _build/default/lib -> required by _build/default/META.multipart_form -> required by _build/install/default/lib/multipart_form/META -> required by _build/default/multipart_form.install -> required by alias install ``` Signed-off-by: Marcello Seri --- packages/multipart_form/multipart_form.0.1.0/opam | 1 + packages/multipart_form/multipart_form.0.4.1/opam | 1 + packages/multipart_form/multipart_form.0.5.0/opam | 1 + 3 files changed, 3 insertions(+) diff --git a/packages/multipart_form/multipart_form.0.1.0/opam b/packages/multipart_form/multipart_form.0.1.0/opam index c7d10297d0e..9898f694769 100644 --- a/packages/multipart_form/multipart_form.0.1.0/opam +++ b/packages/multipart_form/multipart_form.0.1.0/opam @@ -27,6 +27,7 @@ depends: [ "uutf" "stdlib-shims" "pecu" {>= "0.4"} + "result" "fmt" "ke" {>= "0.4"} "alcotest" {with-test} diff --git a/packages/multipart_form/multipart_form.0.4.1/opam b/packages/multipart_form/multipart_form.0.4.1/opam index d33be0ac48a..4ccbac82b02 100644 --- a/packages/multipart_form/multipart_form.0.4.1/opam +++ b/packages/multipart_form/multipart_form.0.4.1/opam @@ -20,6 +20,7 @@ depends: [ "uutf" "pecu" {>= "0.4"} "prettym" + "result" "fmt" {>= "0.8.7"} "logs" "ke" {>= "0.6"} diff --git a/packages/multipart_form/multipart_form.0.5.0/opam b/packages/multipart_form/multipart_form.0.5.0/opam index a1f502c75d0..9b2d561cba0 100644 --- a/packages/multipart_form/multipart_form.0.5.0/opam +++ b/packages/multipart_form/multipart_form.0.5.0/opam @@ -19,6 +19,7 @@ depends: [ "uutf" "pecu" {>= "0.4"} "prettym" + "result" "fmt" {>= "0.8.7"} "logs" "ke" {>= "0.6"} From 4a4e666e882639105182d2098799cceb5833c2d2 Mon Sep 17 00:00:00 2001 From: Marcello Seri Date: Mon, 18 Dec 2023 15:30:14 +0100 Subject: [PATCH 5/5] fat-filesystem requires result Fails with ``` === ERROR while compiling fat-filesystem.0.13.0 ==============================# context 2.2.0~alpha3 | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository path ~/.opam/4.14/.opam-switch/build/fat-filesystem.0.13.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p fat-filesystem -j 71 exit-code 1 env-file ~/.opam/log/fat-filesystem-7-176cf6.env output-file ~/.opam/log/fat-filesystem-7-176cf6.out File "src/dune", line 5, characters 3-9: 5 | result rresult astring) ^^^^^^ Error: Library "result" not found. -> required by library "fat-filesystem" in _build/default/src -> required by _build/default/META.fat-filesystem -> required by _build/install/default/lib/fat-filesystem/META -> required by _build/default/fat-filesystem.install -> required by alias install ``` Signed-off-by: Marcello Seri --- packages/fat-filesystem/fat-filesystem.0.13.0/opam | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/fat-filesystem/fat-filesystem.0.13.0/opam b/packages/fat-filesystem/fat-filesystem.0.13.0/opam index b30b1dd9d9f..42507eca00f 100644 --- a/packages/fat-filesystem/fat-filesystem.0.13.0/opam +++ b/packages/fat-filesystem/fat-filesystem.0.13.0/opam @@ -18,6 +18,7 @@ depends: [ "mirage-block-unix" {>= "2.5.0"} "io-page-unix" {>= "2.0.0"} "re" {>= "1.7.2"} + "result" "cmdliner" "astring" "alcotest" {with-test}