Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda installation for pyxtp #1011

Closed
NicoRenaud opened this issue Dec 13, 2022 · 5 comments
Closed

Conda installation for pyxtp #1011

NicoRenaud opened this issue Dec 13, 2022 · 5 comments

Comments

@NicoRenaud
Copy link
Contributor

Hi @junghans,

together with @baumeier and @suvayu we are trying to finish the development of the python interface for xtp. Most users of the python library would most likely want to install it in a dedicated conda env with all the dependencies they need.

With the current build system, I think users would have to specify the PYTHON_INSTDIR to point to their current conda environment. One solution I could find to allow the installation in the active conda env was to change the the python prefix in the pyxtp Cmake : NicoRenaud@7cffc5a

However I am by no means a CMAKE person and there might be a better solution.

Would you have any idea regarding the install of pyxtp in a conda env ?

Thanks

@junghans
Copy link
Member

Hmm, I am not sure about it.

Wouldn't the right approach be to use -DCMAKE_INSTALL_PREFIX=<your conda env prefix>. Otherwise parts of VOTCA will be installed in the conda env and the rest in CMAKE_INSTALL_PREFIX, which seems bad.

For packaging we need the following use cases:

As a side note cg.get_python_lib() is obsolete so we will need to find another solution for that one, see pdoc3/pdoc#392

@junghans
Copy link
Member

Maybe @jan-janssen can help here, I am not very familiar with setup.py and all these things.

@jan-janssen
Copy link
Contributor

Maybe @jan-janssen can help here, I am not very familiar with setup.py and all these things.

I am a bit confused here. If pyxtp is a python package which can be installed using pip install . then I would assume that it looks for the corresponding libraries in the LIBPATH. So if votac was installed via conda then the corresponding library should already be in the corresponding LIBPATH. The main focus on the conda side is that we want to build the library once and then link to it from all the packages that depend on it. In this case it might be helpful to release the xtp library as standalone package without requiring a full votac installation. Still I guess all this would be much easier to understand if someone could point me to the pyxtp code.

@junghans
Copy link
Member

@NicoRenaud is this still an issue?

@NicoRenaud
Copy link
Contributor Author

Not anymore ! I'll close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants