-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dumping DMD frame need an updated dmddevice.dll #362
Comments
Just had a look and I think this is linked to PinMame but the solution is not in it. As far as I understand, the frame dump code inside VPinMame is a legacy left over since it can't be triggered (it can only be activated when using VPinMame by pressing a key but VPinMame does not have any input access, so it will never be triggered). Therefore, the frame dumping is not done by VPinMame and can't be fixed there (note that the code could be improved to filter out same frame, but since it is not used...). I imagine that you use a dmddevice plugin to perform the dump, likely Freezy's DMDExt. Since latest updates to DMD code, there is an update needed as stated here: #361
@freezy pinging you for visibility on these informations |
Thanks for the info Vincent. You are correct that we are using the DMDEXT (latest beta). I assumed it was a PinMame issue as it went away after rolling back to 998, but I now see it's a bit more elaborate. |
How did you perform the dump before ? |
Same way, but with rawoutput = false, which works with 998 but creates the issues with 1122. |
What do you mean by 'same way' ? without rawoutput=true, it is not supposed to dumpframe at all (see https://github.com/freezy/dmd-extensions?tab=readme-ov-file#frame-dumping) |
ok, my bad, didn't know that creating dmddump would trigger the dumping in PinMame. Will have alook later |
This was very simple, so wrapped up a patch during a break. Should be good now (and also dump alphanumeric systems) |
Dumping ROMs in PinMame 998 works as expected, but in 1122, the dump files are much larger. What is happening is the frames are being repeated multiple times but but with shorter timestamps, so for example one frame of 1000ms from 998 corresponds to ~50 frames of 15-20ms in 1122 making the dump files larger and causing issues for the Serum color authors when playing back the dump files for testing as we are limited to the number of frames that can be loaded. Attached zip file are the first few seconds of the T2 dump files from 998 and 1122.
On the left is 998, you can see the first frame is blank, then the panels start moving in on both sides of the frame on frame 2 (see arrow). On the right is the same dump but from 1122 and the first blank frame is repeated over and over.
![image](https://private-user-images.githubusercontent.com/5919849/381925384-e8f69e64-9d2a-4b71-acb2-7f2c87e04ea0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MzI1NDksIm5iZiI6MTczOTYzMjI0OSwicGF0aCI6Ii81OTE5ODQ5LzM4MTkyNTM4NC1lOGY2OWU2NC05ZDJhLTRiNzEtYWNiMi03ZjJjODdlMDRlYTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMTUxMDQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2Q0YTFlMzg3NzEyNDJiYTVjYmZlMjYzZTUyOTgyODczZDNkZjA1NTk3YjMxOTA4YWI4ZGFhNjBiYjQwODJjMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.RYsdCpORZ649m0K1KKX5JafQ-psfyb6aDbcfpdP9jCo)
Thanks!
Terminator 2 Dumpfiles.zip
The text was updated successfully, but these errors were encountered: