Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better use of pytest #203

Closed
2 of 19 tasks
purva-thakre opened this issue Oct 19, 2023 · 2 comments
Closed
2 of 19 tasks

Better use of pytest #203

purva-thakre opened this issue Oct 19, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@purva-thakre
Copy link
Collaborator

purva-thakre commented Oct 19, 2023

After #196 is fixed, make changes to how pytest is used in toqito/tests.

Things to change:

  • Avoid redefining the same thing in different tests/modules.

More things to be added to the above checklist later.

https://pytest.org/en/7.4.x/explanation/goodpractices.html
https://emimartin.me/pytest_best_practices

  • toqito/channel_metrics #333
  • toqito/channel_ops #336
  • toqito/channel_props
  • toqito/channels
  • toqito/helper
  • toqito/matrices
  • toqito/matrix_ops
  • toqito/matrix_props
  • toqito/measurement_ops
  • toqito/measurement_props
  • toqito/nonlocal_games
  • toqito/perms
  • toqito/rand
  • toqito/state_metrics
  • toqito/state_ops
  • toqito/state_opt
  • toqito/state_props
  • toqito/states
@purva-thakre purva-thakre self-assigned this Oct 19, 2023
@purva-thakre
Copy link
Collaborator Author

purva-thakre commented Nov 14, 2023

After #217 is completed, go back through all the tests in the test module and remove np.testing.

We want to use pytest for testing as some of the tests covered via np.testing were caught as missing by pytest.

isort is currently skipping tests. It might be better to change this later.

@vprusso vprusso added this to the Release 1.0.7 milestone Dec 4, 2023
@purva-thakre purva-thakre modified the milestones: Release 1.0.7, v1.0.8 Jan 4, 2024
@purva-thakre
Copy link
Collaborator Author

Closing this as #488 has more details on what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants