-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move channel dim to channel props #677
Comments
Okay, so I think I fixed this issue. Changes the import pattern a bit, but it works. Let me know what you think, @purva-thakre |
Yes, but shouldn't we be consistent with all the other input patterns? I think the issue I ran into was the problem persists if we apply the same input pattern to all of them. If we use ruff for formatting, it will catch these differences. I say we keep this or the other issue open to understand why one input pattern works while the other doesn't. |
Yes, I agree. It's definitely an awkward hack that is not consistent with the way we do things elsewhere. It's a difficult bug to diagnose as running the tests for Agree with keeping the issue open and attempting to fix properly. |
It seems as if the
helper/channel_dim.py
file should live instead inchannel_props/channel_dim.py
as this is a property of a given quantum channel.The text was updated successfully, but these errors were encountered: