Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move channel dim to channel props #677

Open
vprusso opened this issue Jul 13, 2024 · 4 comments
Open

Move channel dim to channel props #677

vprusso opened this issue Jul 13, 2024 · 4 comments
Labels
bug Something isn't working devops help wanted Extra attention is needed

Comments

@vprusso
Copy link
Owner

vprusso commented Jul 13, 2024

It seems as if the helper/channel_dim.py file should live instead in channel_props/channel_dim.py as this is a property of a given quantum channel.

@purva-thakre
Copy link
Collaborator

This is a duplicate of #244

The failures in #680 are identical to the attempts I made to resolve the issue. Still don't know the cause behind TypeError: 'module' object is not callable

@vprusso
Copy link
Owner Author

vprusso commented Jul 15, 2024

Okay, so I think I fixed this issue. Changes the import pattern a bit, but it works. Let me know what you think, @purva-thakre

@purva-thakre
Copy link
Collaborator

Yes, but shouldn't we be consistent with all the other input patterns? I think the issue I ran into was the problem persists if we apply the same input pattern to all of them. If we use ruff for formatting, it will catch these differences.

I say we keep this or the other issue open to understand why one input pattern works while the other doesn't.

@vprusso
Copy link
Owner Author

vprusso commented Jul 15, 2024

Yes, I agree. It's definitely an awkward hack that is not consistent with the way we do things elsewhere. It's a difficult bug to diagnose as running the tests for channel_props/ works fine without altering the pattern but then trying to run all the tests seems to fail if that pattern is not used. It's probably some "circular-import-type-thing" but it's not obvious to me what it is.

Agree with keeping the issue open and attempting to fix properly.

@purva-thakre purva-thakre added bug Something isn't working help wanted Extra attention is needed devops and removed good first issue Good for newcomers labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants