Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Run webhook server in a dedicated deployment #101

Open
ccremer opened this issue Jul 6, 2022 · 0 comments
Open

Run webhook server in a dedicated deployment #101

ccremer opened this issue Jul 6, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ccremer
Copy link
Contributor

ccremer commented Jul 6, 2022

Summary

As cluster-admin
I want to run the webhook server in its own pod
So that** that crashloops of the operator doesn't affect the ability to edit instances.

Context

Currently (v0.1.1) both operator and webhook are in the same container and pod.
If the controller encounters an unrecoverable error (such as a panic) then the chances are high that the container ends up in a crashloop. This means that the webhook server also gets constantly restarted.

Consider this scenario:

  • Instance object is in a broken state
  • Operator tries to reconcile instance, but panics and crashloops
  • A user tries to fix the instance by editing the broken spec -> user can't do this since kubernetes can't reach the webhook server

Out of Scope

No response

Further links

No response

Acceptance Criteria

No response

Implementation Ideas

  • Run the webhook part as a separate CLI subcommand in its own deployment
  • Adapt the helm chart accordingly
@ccremer ccremer added the enhancement New feature or request label Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant